Skip to content

Commit

Permalink
[ci] Convert version presubmit check to LUCI (flutter#4822)
Browse files Browse the repository at this point in the history
Adds a LUCI version of the version presubmit check, using the new label passthrough functionality, and removes it from Cirrus. Since that was the last Cirrus task, this removes the entire Cirrus config, and the associated Dockerfile.

Part of flutter/flutter#130076
  • Loading branch information
stuartmorgan authored Aug 31, 2023
1 parent e668c43 commit c9a2584
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 48 deletions.
6 changes: 0 additions & 6 deletions .ci/Dockerfile

This file was deleted.

7 changes: 3 additions & 4 deletions .ci/scripts/check_version.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,13 @@
# found in the LICENSE file.
set -e

# For pre-submit, this is currently run in Cirrus; see TODO below.
# For pre-submit, check for missing or breaking changes that don't have a
# corresponding override label.
# For post-submit, ignore platform interface breaking version changes and
# missing version/CHANGELOG detection since PR-level overrides aren't available
# in post-submit.
if [[ $LUCI_PR == "" ]]; then
./script/tool_runner.sh version-check --ignore-platform-interface-breaks
else
# TODO(stuartmorgan): Migrate this check from Cirrus. See
# https://github.com/flutter/flutter/issues/130076
:
./script/tool_runner.sh version-check --check-for-missing-changes --pr-labels="$PR_OVERRIDE_LABELS"
fi
9 changes: 5 additions & 4 deletions .ci/targets/repo_checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,14 @@ tasks:
script: script/tool_runner.sh
args: ["dependabot-check"]
always: true
- name: publishability
script: script/tool_runner.sh
args: ["publish-check", "--allow-pre-release"]
always: true
- name: CHANGELOG and version validation
script: .ci/scripts/check_version.sh
always: true
- name: federated safety check
script: .ci/scripts/check_federated_safety.sh
always: true
# This is the slowest test, so prefer keeping it last.
- name: publishability
script: script/tool_runner.sh
args: ["publish-check", "--allow-pre-release"]
always: true
34 changes: 0 additions & 34 deletions .cirrus.yml

This file was deleted.

0 comments on commit c9a2584

Please sign in to comment.