Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace imp with importlib #74

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Replace imp with importlib #74

merged 2 commits into from
Nov 5, 2024

Conversation

figi44
Copy link
Contributor

@figi44 figi44 commented Oct 31, 2024

This replaces imp module with importlib, and makes argparse2tool compatible with python 3.12 and newer. The reason is that imp module is deprecated since python 3.4 and was removed in 3.12.

I'm using this tool (and really like it so far!) in a cwl generator and would like to also support current python versions. Thanks!

imp is removed in ^3.12
@mr-c
Copy link
Collaborator

mr-c commented Oct 31, 2024

Thank you @figi44 ; I would enjoy hearing more about your CWL generator!

@figi44
Copy link
Contributor Author

figi44 commented Nov 4, 2024

Could someone please look at the failing CI? Looks like it's running into usage error here.

@mr-c, we're using this to automate earth observation application package generation, feel free to have a look - https://github.com/EO-DataHub/eoap-gen

@hexylena hexylena self-assigned this Nov 4, 2024
@hexylena
Copy link
Owner

hexylena commented Nov 5, 2024

It looks like planemo no longer needs the --xsd flag.

Copy link
Owner

@hexylena hexylena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

@hexylena hexylena merged commit 734d1d7 into hexylena:main Nov 5, 2024
1 check passed
@hexylena
Copy link
Owner

hexylena commented Nov 5, 2024

0.5.2 is out on pypi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants