Skip to content

Commit

Permalink
Disable signing and publishing on perf builds (dotnet/coreclr#26390)
Browse files Browse the repository at this point in the history
* Disable signing and publishing on perf builds

* Mark default to false

* Change to signBinaries and publishToBlobFeed


Commit migrated from dotnet/coreclr@8feac49
  • Loading branch information
michellemcdaniel authored Aug 28, 2019
1 parent 4018a61 commit 89addf5
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 4 additions & 2 deletions eng/build-job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ parameters:
container: ''
crossrootfsDir: ''
timeoutInMinutes: ''
signBinaries: false
publishToBlobFeed: false

### Product build
jobs:
Expand Down Expand Up @@ -125,7 +127,7 @@ jobs:
displayName: Build product

# Sign on Windows
- ${{ if and(ne(variables['System.TeamProject'], 'public'), ne(variables['Build.Reason'], 'PullRequest'), eq(parameters.osGroup, 'Windows_NT')) }}:
- ${{ if and(eq(parameters.osGroup, 'Windows_NT'), eq(parameters.signBinaries, 'true')) }}:
- powershell: eng\common\build.ps1 -ci -sign -restore -configuration:$(buildConfig) -warnaserror:0 /p:ArcadeBuild=true /p:OfficialBuild=true /p:BuildOS=$(osGroup) /p:BuildArch=$(archType) /p:BuildType=$(_BuildConfig) /p:DotNetSignType=$env:_SignType -projects $(Build.SourcesDirectory)\eng\empty.csproj
displayName: Sign Binaries

Expand Down Expand Up @@ -162,7 +164,7 @@ jobs:
displayName: Build packages

# Publish official build
- ${{ if and(ne(variables['System.TeamProject'], 'public'), ne(variables['Build.Reason'], 'PullRequest')) }}:
- ${{ if eq(parameters.publishToBlobFeed, 'true') }}:
- ${{ if ne(parameters.osGroup, 'Windows_NT') }}:
- script: ./eng/common/build.sh --ci --restore --publish --configuration $(_BuildConfig) /p:DotNetPublishUsingPipelines=true /p:DotNetPublishToBlobFeed=true /p:DotNetPublishBlobFeedUrl=$(dotnetfeedUrl) /p:DotNetPublishBlobFeedKey=$(dotnetfeedPAT) /p:__BuildType=$(_BuildConfig) /p:__BuildArch=$(archType) /p:__BuildOS=$(osGroup) /p:OSIdentifier=$(osIdentifier) /bl:"$(Build.SourcesDirectory)/bin/Logs/publish-pkgs.binlog" --projects $(Build.SourcesDirectory)/eng/empty.csproj
displayName: Publish packages to blob feed
Expand Down
2 changes: 2 additions & 0 deletions eng/pipelines/coreclr/internal.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ stages:
# due to waiting for an exclusive lock on the feed.
# See https://github.com/dotnet/arcade/blob/master/Documentation/CorePackages/AsyncPublishing.md
timeoutInMinutes: 120
signBinaries: true
publishToBlobFeed: true

#
# Publish build information to Build Assets Registry
Expand Down

0 comments on commit 89addf5

Please sign in to comment.