Skip to content

Commit

Permalink
Disable autodetection of warnings in CoreCLR subrepo build (dotnet#153)
Browse files Browse the repository at this point in the history
CoreCLR subrepo build has a known existing warning coming from
pgomgr that Arcade upgrades to an error via WarnAsError. I propose
suppressing autodetection of warnings in CoreCLR build to fix this
spurious bug reproducing in release mode.

Thanks

Tomas

Fixes: dotnet#150
Follow-up tracking issue: dotnet#156
  • Loading branch information
trylek authored Nov 21, 2019
1 parent 8e93e72 commit a34031f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/coreclr/coreclr.proj
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
<_CoreClrBuildScript Condition="!$([MSBuild]::IsOsPlatform(Windows))">build.sh</_CoreClrBuildScript>
</PropertyGroup>

<Exec Command="&quot;$(MSBuildThisFileDirectory)$(_CoreClrBuildScript)&quot; @(_CoreClrBuildArg->'%(Identity)',' ')" />
<!-- Use IgnoreStandardErrorWarningFormat because Arcade sets WarnAsError and there's an existing warning in the native build. -->
<Exec Command="&quot;$(MSBuildThisFileDirectory)$(_CoreClrBuildScript)&quot; @(_CoreClrBuildArg->'%(Identity)',' ')" IgnoreStandardErrorWarningFormat="true" />
</Target>

<Target Name="Restore" />
Expand Down

0 comments on commit a34031f

Please sign in to comment.