This repository has been archived by the owner on Oct 1, 2023. It is now read-only.
Tags: hhvm/hh-clilib
Tags
Update tests for HSL IO v0.2 (#32) * Update tests for HSL IO v0.2 I think the logic being tested was bad; there are two classes of issues here: - `IO\MemoryHandle` works like a read-write file. `TestLib\StringInput` was... unique. Use pipes where we need funky stuff. In particular, if it's closed, it can't be read from. - Checking `isEndOfFile()` before echoing the `> ` prompt was a bug and undefined behavior really - consistently prompt before attempting to get input * disable hhast testing temporarily - circular dependency * Guarantee ordering for '(Before|After)Start' * comment out full hhast if block * Require HHVM 4.60 Dependencies need it anyway; even though it's only for dev-depends, don't want to support a version that can't be tested
Update tests for HSL IO v0.2 (#32) * Update tests for HSL IO v0.2 I think the logic being tested was bad; there are two classes of issues here: - `IO\MemoryHandle` works like a read-write file. `TestLib\StringInput` was... unique. Use pipes where we need funky stuff. In particular, if it's closed, it can't be read from. - Checking `isEndOfFile()` before echoing the `> ` prompt was a bug and undefined behavior really - consistently prompt before attempting to get input * disable hhast testing temporarily - circular dependency * Guarantee ordering for '(Before|After)Start' * comment out full hhast if block * Require HHVM 4.60 Dependencies need it anyway; even though it's only for dev-depends, don't want to support a version that can't be tested
PreviousNext