cmd/pprof: ignore symbols with address 0 and size 0

Handling a symbol with address 0 and size 0, such as an ELF STT_FILE symbols, was causing us to disassemble the entire program. We started adding STT_FILE symbols to help fix issue golang#13247. Fixes golang#16154. Change-Id: I174b9614e66ddc3d65801f7c1af7650f291ac2af Reviewed-on: https://go-review.googlesource.com/24460 Run-TryBot: Ian Lance Taylor <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Joe Tsai <[email protected]>
hick · Jun 24, 2016 · 83e839f · 83e839f
1 parent 5e43dc9
commit 83e839f
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/cmd/pprof/pprof.go b/src/cmd/pprof/pprof.go
@@ -308,6 +308,11 @@ func (f *file) Symbols(r *regexp.Regexp, addr uint64) ([]*plugin.Sym, error) {
 	}
 	var out []*plugin.Sym
 	for _, s := range f.sym {
+		// Ignore a symbol with address 0 and size 0.
+		// An ELF STT_FILE symbol will look like that.
+		if s.Addr == 0 && s.Size == 0 {
+			continue
+		}
 		if (r == nil || r.MatchString(s.Name)) && (addr == 0 || s.Addr <= addr && addr < s.Addr+uint64(s.Size)) {
 			out = append(out, &plugin.Sym{
 				Name:  []string{s.Name},