MDL-30506 navigation: Fixed up reference handling issue and added doc…

…s post integration

lib/navigationlib.php

@@ -4400,9 +4400,9 @@ protected function load_front_page_settings($forceopen = false) {
      */
     protected function load_local_plugin_settings() {
         // Get all local plugins with an extend_settings_navigation function in their lib.php file
-        foreach (get_plugin_list_with_function('local', 'extend_settings_navigation') as $function) {
+        foreach (get_plugin_list_with_function('local', 'extends_settings_navigation') as $function) {
             // Call each function providing this (the settings navigation) and the current context.
-            call_user_func($function, $this, $this->context);
+            $function($this, $this->context);
         }
     }
 

local/readme.txt

@@ -205,6 +205,25 @@ You will need to write the /local/nicehack/externallib.php - external functions
 description and code. See some examples from the core files (/user/externallib.php,
 /group/externallib.php...).
 
+Local plugin navigation hooks
+-----------------------------
+There are two functions that your plugin can define that allow it to extend the main
+navigation and the settings navigation.
+These two functions both need to be defined within /local/nicehack/lib.php.
+
+sample code
+<?php
+function nicehack_extends_navigation(global_navigation $nav) {
+    // $nav is the global navigation instance.
+    // Here you can add to and manipulate the navigation structure as you like.
+    // This callback was introduced in 2.0
+}
+function local_nicehack_extends_settings_navigation(settings_navigation $nav, context $context) {
+    // $nav is the settings navigation instance.
+    // $context is the context the settings have been loaded for (settings is context specific)
+    // Here you can add to and manipulate the settings structure as you like.
+    // This callback was introduced in 2.3
+}
 
 Other local customisation files
 ===============================