js: Fix interaction between ES6 modules and meshopt_decoder.js

meshopt_decoder.js used a UMD-style export copied from Emscripten that didn't support ES6 modules, so attempts to import the .js file would fail. It doesn't look like there's a good way to make exports fully work without having a separate .js file, as `export {}` statement can't be conditional on the support of ES6 syntax. So the next best thing appears to be to explicitly inject the value into the global scope, which this change now does. Also fix README.md for gltfpack to use import code that actually works.
hilbert-yaa · Jun 14, 2020 · 9c67eea · 9c67eea
1 parent 9e89bf3
commit 9c67eea
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/gltf/README.md b/gltf/README.md
@@ -31,7 +31,7 @@ gltfpack can also compress textures using Basis Universal format, either storing
 When using compressed files, [js/meshopt_decoder.js](https://github.com/zeux/meshoptimizer/blob/master/js/meshopt_decoder.js) needs to be loaded to provide the WebAssembly decoder module like this:
 
 ```js
-import MeshoptDecoder from "./meshopt_decoder";
+import './meshopt_decoder.js'; // imports MeshoptDecoder using ES6
 
 ...
 

diff --git a/js/meshopt_decoder.js b/js/meshopt_decoder.js
-Original file line number
+Diff line change
@@ Expand Up @@
     When using compressed files, [js/meshopt_decoder.js](https://github.com/zeux/meshoptimizer/blob/master/js/meshopt_decoder.js) needs to be loaded to provide the WebAssembly decoder module like this:
     ```js
-    import MeshoptDecoder from "./meshopt_decoder";
+    import './meshopt_decoder.js'; // imports MeshoptDecoder using ES6
     ...
@@ Expand Down @@