Some Enhancement (line#162)

* misc: remove polyfill for Nodejs version below 6

* refact: change NumberOfSentBroadcastMessages to NumberOfMessagesSentResponse

* add test for uncovered lines

* add test when set non-Buffer to setRichMenu

* remove no meaning try catch

docs/api-reference/client.md

@@ -56,7 +56,7 @@ class Client {
   getNumberOfSentMulticastMessages(date: string): Promise<NumberOfMessagesSentResponse>
   getTargetLimitForAdditionalMessages(): Promise<TargetLimitForAdditionalMessages>
   getNumberOfMessagesSentThisMonth(): Promise<NumberOfMessagesSentThisMonth>
-  getNumberOfSentBroadcastMessages(date: string): Promise<NumberOfSentBroadcastMessages>
+  getNumberOfSentBroadcastMessages(date: string): Promise<NumberOfMessagesSentResponse>
 }
 ```
 
@@ -485,7 +485,7 @@ client.getNumberOfMessagesSentThisMonth().then((response) => {
 })
 ```
 
-#### `getNumberOfSentBroadcastMessages(date: string): Promise<NumberOfSentBroadcastMessages>`
+#### `getNumberOfSentBroadcastMessages(date: string): Promise<NumberOfMessagesSentResponse>`
 
 Gets the number of messages sent with the `/bot/message/broadcast` endpoint.
 

lib/client.ts

@@ -307,8 +307,8 @@ export default class Client {
 
   public async getNumberOfSentBroadcastMessages(
     date: string,
-  ): Promise<Types.NumberOfSentBroadcastMessages> {
-    const res = await this.http.get<Types.NumberOfSentBroadcastMessages>(
+  ): Promise<Types.NumberOfMessagesSentResponse> {
+    const res = await this.http.get<Types.NumberOfMessagesSentResponse>(
       `/message/delivery/broadcast?date=${date}`,
     );
     return ensureJSON(res);

lib/types.ts

@@ -1784,23 +1784,6 @@ export type NumberOfMessagesSentThisMonth = {
   totalUsage: number;
 };
 
-export type NumberOfSentBroadcastMessages = {
-  /**
-   * Status of the counting process. One of the following values is returned:
-   *  - `ready`: You can get the number of messages.
-   *  - `unready`: The message counting process for the date specified in date has not been completed yet.
-   *     Retry your request later. Normally, the counting process is completed within the next day.
-   *  - `out_of_service`: The date specified in date is earlier than March 31, 2018,
-   *     when the operation of the counting system started.
-   */
-  status: "ready" | "unready" | "out_of_service";
-  /**
-   * The number of messages sent with the Messaging API on the date specified in `date`.
-   * The response has this property only when the value of `status` is `ready`.
-   */
-  success?: number;
-};
-
 export const LINE_REQUEST_ID_HTTP_HEADER_NAME = "x-line-request-id";
 export type MessageAPIResponseBase = {
   [LINE_REQUEST_ID_HTTP_HEADER_NAME]?: string;

lib/validate-signature.ts

@@ -1,14 +1,7 @@
 import { createHmac, timingSafeEqual } from "crypto";
 
 function s2b(str: string, encoding: string): Buffer {
-  try {
-    return Buffer.from(str, encoding);
-  } catch (err) {
-    if (err.name === "TypeError") {
-      return new Buffer(str, encoding);
-    }
-    throw err;
-  }
+  return Buffer.from(str, encoding);
 }
 
 function safeCompare(a: Buffer, b: Buffer): boolean {

test/client.spec.ts

@@ -1,6 +1,6 @@
 import { readFileSync } from "fs";
 import { join } from "path";
-import { deepEqual, equal } from "assert";
+import { deepEqual, equal, ok } from "assert";
 import Client from "../lib/client";
 import * as Types from "../lib/types";
 import { getStreamData } from "./helpers/stream";
@@ -10,7 +10,6 @@ const TEST_PORT = parseInt(process.env.TEST_PORT, 10);
 
 const client = new Client({
   channelAccessToken: "test_channel_access_token",
-  channelSecret: "test_channel_secret",
 });
 
 const getRecentReq = (): any =>
@@ -397,4 +396,22 @@ describe("client", () => {
     equal(req.query.date, date);
     equal(req.method, "GET");
   });
+
+  it("fails on construct with no channelAccessToken", () => {
+    try {
+      new Client({ channelAccessToken: null });
+      ok(false);
+    } catch (err) {
+      equal(err.message, "no channel access token");
+    }
+  });
+
+  it("fails on pass non-Buffer to setRichMenu", async () => {
+    try {
+      await client.setRichMenuImage("test_rich_menu_id", null);
+      ok(false);
+    } catch (err) {
+      equal(err.message, "invalid data type for postBinary");
+    }
+  });
 });

test/middleware.spec.ts

@@ -83,6 +83,15 @@ describe("middleware", () => {
     deepEqual(req.body.events, [webhook]);
   });
 
+  it("fails on construct with no channelSecret", () => {
+    try {
+      middleware({ channelSecret: null });
+      ok(false);
+    } catch (err) {
+      equal(err.message, "no channel secret");
+    }
+  });
+
   it("fails on wrong signature", async () => {
     try {
       await http({
@@ -101,6 +110,24 @@ describe("middleware", () => {
     }
   });
 
+  it("fails on wrong signature (length)", async () => {
+    try {
+      await http({
+        "X-Line-Signature": "WqJD7WAIZ6plkQGkj48w=",
+      }).post(`/webhook`, {
+        events: [webhook],
+        destination: "Uaaaabbbbccccddddeeeeffff",
+      });
+      ok(false);
+    } catch (err) {
+      if (err instanceof HTTPError) {
+        equal(err.statusCode, 401);
+      } else {
+        throw err;
+      }
+    }
+  });
+
   it("fails on invalid JSON", async () => {
     try {
       await http({