Skip to content

Commit

Permalink
Solve the unexpected error at the end of the queued tasks running
Browse files Browse the repository at this point in the history
fix: iterative#8615
1. This is because, at the end of the tasks,
the temp running directly will be deleted

1. Only fetch result during running (not during the result collection)
2. Bump into scmrepo 0.1.4 in which we wrapped `KeyError` into
   `SCMError`.
  • Loading branch information
karajan1001 committed Nov 29, 2022
1 parent 6a9fbaf commit 3ba6b1f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion dvc/repo/experiments/queue/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def fetch_running_exp_from_temp_dir(
info = ExecutorInfo.from_dict(load_json(infofile))
except OSError:
return result
if info.status < TaskStatus.FAILED:
if info.status <= TaskStatus.RUNNING:
result[rev] = info.asdict()
if info.git_url and fetch_refs and info.status > TaskStatus.PREPARING:

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ dependencies = [
"rich>=10.13.0",
"pyparsing>=2.4.7",
"typing-extensions>=3.7.4",
"scmrepo==0.1.3",
"scmrepo==0.1.4",
"dvc-render==0.0.14",
"dvc-task==0.1.6",
"dvclive>=1.0",
Expand Down

0 comments on commit 3ba6b1f

Please sign in to comment.