makedirs: add comment on why do have to use umask

hiroto7 · Nov 19, 2019 · aa6a772 · aa6a772
1 parent ecfbc3a
commit aa6a772
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/dvc/utils/__init__.py b/dvc/utils/__init__.py
@@ -152,6 +152,9 @@ def makedirs(path, exist_ok=False, mode=None):
         _makedirs(path, exist_ok=exist_ok)
         return
 
+    # utilize umask to set proper permissions since Python 3.7 the `mode`
+    # `makedirs` argument no longer affects the file permission bits of
+    # newly-created intermediate-level directories.
     umask = os.umask(0o777 - mode)
     try:
         _makedirs(path, exist_ok=exist_ok)