Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework docker setup #1

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

norpol
Copy link

@norpol norpol commented Nov 14, 2022

First of all, incredible big thank you for this code. I'm a total C/C++ noob and didn't realize it was that easily possible.

I think there might be some cool ideas possible with this project.

I've managed to get a stream running, for this I've decided to rework Dockerfile and some of the scripts. Although I'm happy to add some of the functionality back. See this pull request as a first draft of a clearer setup. I'm also going to add GitHub action for the docker building maybe.

Anyhow.

  • Dockerfile has a builder step that runs make itself
  • I've dropped make docker and some of the copying stages
  • I've renamed the make commands, this way outdir isn't needed in each command
  • I've made outdir overrideable by using ?= instead of = I can do export outdir="dir" since ../ would have been a bit messy inside the Dockerfile
  • Simplified the docker entrypoint a bit (I know this is probably less stable)
  • Updated the Docker instructions in README

I'm seeing this as a first draft, as I don't know how many changes/which changes you like to get. I'll adjust anything regarding your feedback.

@hisptoot
Copy link
Owner

hisptoot commented Dec 3, 2022

Thank you for the improvements. I will check the code and merge your code after I finish the config file generation function.

@norpol
Copy link
Author

norpol commented Dec 3, 2022

Thanks for checking it out, please leave some review and let me know if you're happy with the direction. I'm happy to rebase/test everything once you've figured out the #2 solution. I thought maybe adding some WebUI might be cool extension (might be needed anyway if we are doing the oauth-login procedure that the BambuStudio does).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants