Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lua keymaps &c. #56

Merged
merged 18 commits into from
Jun 1, 2022
Merged

Lua keymaps &c. #56

merged 18 commits into from
Jun 1, 2022

Conversation

hjdivad
Copy link
Owner

@hjdivad hjdivad commented May 28, 2022

Make more things pure lua

  • convert some more of hjdivad_init (maybe even with tests)
  • ship initial setup malleatus/common.nvim#1
  • fix plugin installation
    • Dig into the list of problem plugins & see if there's missing deps
    • For those that remain, install only if there are UIs #nvim_list_uis() > 0
  • drop local linking

Plugin installation has two issues

  1. Some plugins depend on other plugins already having been loaded (fixed)
  2. Some plugins do not load well in CI.

One way of dealing with the plugins in 2 is telling paq the plugins are optional and then in non-ci packadding them but ignoring them in CI.

@hjdivad hjdivad force-pushed the hjdivad/lua-keymaps-etc branch 2 times, most recently from 22a9c46 to 97117ab Compare May 29, 2022 23:14
@hjdivad hjdivad mentioned this pull request May 30, 2022
2 tasks
hjdivad added 12 commits May 30, 2022 08:24
Mainly because the main function in hjdivad_init is called main and it's
a bit confusing right now.
Still prepend a local `malleatus/common.nvim` until there's a reasonable
v0.1 on github/master.
Rather than as an extra command line argument. This way we more
explicitly wait on plugin installation before exiting neovim and might
handle some async cases better.
@hjdivad hjdivad force-pushed the hjdivad/lua-keymaps-etc branch 3 times, most recently from 62c68fe to 757ea85 Compare May 30, 2022 18:06
hjdivad added 6 commits June 1, 2022 07:08
* Move ssh setup prior to plugin installation so it can be debugged
* Plugin installation accepts NVIM_FLAGS from secret NvimFlags to allow
  debugging (via e.g. `-V12`)
This disable's vim-markdown's folding, which is sometimes useful as it
doesn't play very well with treesitter.  In the longrun the thing to do
is to improve the markdown grammar / treesitter's folding expr to get
treesitter folding to work well without vim-markdown.
A reasonable initial version of common.nvim is now on github so we can
actually just install it.
@hjdivad hjdivad force-pushed the hjdivad/lua-keymaps-etc branch from d98b147 to a056b87 Compare June 1, 2022 14:12
@hjdivad
Copy link
Owner Author

hjdivad commented Jun 1, 2022

End result is a bit janky -- just don't install the problem plugins in CI. Fine for now but it obviously means they can't be tested.

@hjdivad hjdivad merged commit 6151bc3 into master Jun 1, 2022
@hjdivad hjdivad deleted the hjdivad/lua-keymaps-etc branch June 1, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant