jsonrpc: Don't assert for 0 remotes in jsonrpc_session_open_multiple().

It's pretty easy to get 0 remotes here from ovn-northd if you specify --ovnnb-db='' or --ovnnb-db=' ' on the command line. The internals of jsonrpc_session aren't equipped to cope with that, so just add a dummy remote instead. Acked-by: Numan Siddique <[email protected]> Signed-off-by: Ben Pfaff <[email protected]>
hlyycc · Jun 29, 2020 · f740828 · f740828
1 parent 7d68168
commit f740828
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/jsonrpc.c b/lib/jsonrpc.c
@@ -825,8 +825,10 @@ jsonrpc_session_open_multiple(const struct svec *remotes, bool retry)
     s = xmalloc(sizeof *s);
 
     /* Set 'n' remotes from 'names'. */
-    ovs_assert(remotes->n > 0);
     svec_clone(&s->remotes, remotes);
+    if (!s->remotes.n) {
+        svec_add(&s->remotes, "invalid:");
+    }
     s->next_remote = 0;
 
     s->reconnect = reconnect_create(time_msec());