Skip to content

Commit

Permalink
Merge pull request traccar#4166 from mujeerhashmi/mapmyindia
Browse files Browse the repository at this point in the history
Implement MapmyIndia Reverse geocoder
  • Loading branch information
tananaev authored Dec 18, 2018
2 parents 85cd0f9 + 0e39aad commit d0798cd
Show file tree
Hide file tree
Showing 3 changed files with 77 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/org/traccar/Context.java
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
import org.traccar.geocoder.MapQuestGeocoder;
import org.traccar.geocoder.NominatimGeocoder;
import org.traccar.geocoder.OpenCageGeocoder;
import org.traccar.geocoder.MapmyIndiaGeocoder;
import org.traccar.geocoder.Geocoder;
import org.traccar.geolocation.UnwiredGeolocationProvider;
import org.traccar.helper.Log;
Expand Down Expand Up @@ -351,6 +352,8 @@ public static Geocoder initGeocoder() {
return new BanGeocoder(cacheSize, addressFormat);
case "here":
return new HereGeocoder(id, key, language, cacheSize, addressFormat);
case "mapmyindia":
return new MapmyIndiaGeocoder(url, key, cacheSize, addressFormat);
default:
return new GoogleGeocoder(key, language, cacheSize, addressFormat);
}
Expand Down
67 changes: 67 additions & 0 deletions src/org/traccar/geocoder/MapmyIndiaGeocoder.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
package org.traccar.geocoder;

import javax.json.JsonArray;
import javax.json.JsonObject;

public class MapmyIndiaGeocoder extends JsonGeocoder {

public MapmyIndiaGeocoder(String url, String key, int cacheSize, AddressFormat addressFormat) {
super(url + "/" + key + "/rev_geocode?lat=%f&lng=%f", cacheSize, addressFormat);
}

@Override
public Address parseAddress(JsonObject json) {
JsonArray results = json.getJsonArray("results");

if (!results.isEmpty()) {
Address address = new Address();

JsonObject result = (JsonObject) results.get(0);

if (result.containsKey("formatted_address")) {
address.setFormattedAddress(result.getString("formatted_address"));
}

if (result.containsKey("house_number") && (result.getString("house_number") != "")) {
address.setHouse(result.getString("house_number"));
} else if (result.containsKey("house_name") && (result.getString("house_name") != "")) {
address.setHouse(result.getString("house_name"));
}

if (result.containsKey("street")) {
address.setStreet(result.getString("street"));
}

if (result.containsKey("locality") && (result.getString("locality") != "")) {
address.setSuburb(result.getString("locality"));
} else if (result.containsKey("sublocality") && (result.getString("sublocality") != "")) {
address.setSuburb(result.getString("sublocality"));
} else if (result.containsKey("subsublocality") && (result.getString("subsublocality") != "")) {
address.setSuburb(result.getString("subsublocality"));
}

if (result.containsKey("city") && (result.getString("city") != "")) {
address.setSettlement(result.getString("city"));
} else if (result.containsKey("village") && (result.getString("village") != "")) {
address.setSettlement(result.getString("village"));
}

if (result.containsKey("district")) {
address.setDistrict(result.getString("district"));
} else if (result.containsKey("subDistrict")) {
address.setDistrict(result.getString("subDistrict"));
}

if (result.containsKey("state")) {
address.setState(result.getString("state"));
}

if (result.containsKey("pincode")) {
address.setPostcode(result.getString("pincode"));
}

return address;
}
return null;
}
}
7 changes: 7 additions & 0 deletions test/org/traccar/geocoder/GeocoderTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -78,4 +78,11 @@ public void testHere() {
assertEquals("6 Avenue Gustave Eiffel, Paris, Île-de-France, FRA", address);
}

@Ignore
@Test
public void testMapmyIndia() {
Geocoder geocoder = new MapmyIndiaGeocoder("", "", 0, new AddressFormat("%f"));
String address = geocoder.getAddress(28.6129602407977, 77.2294557094574, null);
assertEquals("New Delhi, Delhi. 1 m from India Gate pin-110001 (India)", address);
}
}

0 comments on commit d0798cd

Please sign in to comment.