ITSASU-3596 - Build + Integrate new start date limit question and flow #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ILee15
reviewed
Feb 7, 2025
conf/messages
Outdated
| individual.foreign-property.start-date.hint = For example, 27 9 {0}. | ||
|
|
||
| # Foreign Property Start Date Errors | ||
| error.individual.foreign-property.day-month-year.empty = Enter the date your foreign property business started trading |
There was a problem hiding this comment.
Could you update the following English error messages please:
- all empty
- max date
- min date
- year must be 4 numbers
The welsh looks OK.
| @@ -14,9 +14,10 @@ | |||
| * limitations under the License. | |||
| *@ | |||
|
|
|||
| @import forms.individual.business.OverseasPropertyStartDateForm._ | |||
| @import forms.individual.business.PropertyStartDateForm._ | |||
There was a problem hiding this comment.
Imported the UK Property start date form here
| } | ||
| } | ||
| } | ||
| "return a form error" when { |
There was a problem hiding this comment.
Could add tests for min and max date
| @@ -45,10 +45,10 @@ class OverseasPropertyStartDateViewSpec extends ViewSpec { | |||
| val backUrl: String = testBackUrl | |||
| val action: Call = testCall | |||
| val taxYearEnd: Int = 2020 | |||
| val testError: FormError = FormError("startDate", "error.overseas.property.day-month-year.empty") | |||
There was a problem hiding this comment.
I take it there was 1 set of messages for both ind/agent? Will be good to let Yonis know the message keys are changing :)
There was a problem hiding this comment.
Ah, not quite, this was updated incorrectly, I mass updated it and it caught this which was wrong to begin with, there are agent specific messages for this, I'll convert this to the agent message
AlexRimmerHMRC
force-pushed
the
ITSASU-3596
branch
from
31379b9 to
61e0561
Compare
AlexRimmerHMRC
force-pushed
the
ITSASU-3596
branch
from
61e0561 to
336c550
Compare
ILee15
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.