Skip to content

Commit

Permalink
nopSolutions#4633 Move TODO to the work item
Browse files Browse the repository at this point in the history
  • Loading branch information
RomanovM committed Apr 30, 2020
1 parent beae8da commit f1aee2f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ public virtual string FormatAttributes(Product product, string attributesXml,
if (htmlEncode)
fileName = WebUtility.HtmlEncode(fileName);

//TODO add a method for getting URL (use routing because it handles all SEO friendly URLs)
var attributeText = allowHyperlinks ? $"<a href=\"{_webHelper.GetStoreLocation(false)}download/getfileupload/?downloadId={download.DownloadGuid}\" class=\"fileuploadattribute\">{fileName}</a>"
: fileName;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ public virtual string FormatAttributes(string attributesXml,
var download = _downloadService.GetDownloadByGuid(downloadGuid);
if (download != null)
{
//TODO add a method for getting URL (use routing because it handles all SEO friendly URLs)
string attributeText;
var fileName = $"{download.Filename ?? download.DownloadGuid.ToString()}{download.Extension}";
//encode (if required)
Expand Down

0 comments on commit f1aee2f

Please sign in to comment.