Skip to content

Commit

Permalink
chore: replace AbstractEvent with CustomEvent
Browse files Browse the repository at this point in the history
  • Loading branch information
@hnrq
hnrq committed Aug 15, 2022
1 parent e95e1ac commit 5c5b3a1
Show file tree
Hide file tree
Showing 47 changed files with 858 additions and 860 deletions.
8 changes: 0 additions & 8 deletions esdoc.json
View file

This file was deleted.

2 changes: 1 addition & 1 deletion examples/src/routes/examples/draggable/drag-events/index.svelte
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
});
draggable.on('mirror:move', (evt: MirrorMoveEvent) => {
evt.cancel();
evt.preventDefault();
const offsetX = evt.sensorEvent.clientX - initialMousePosition.x;
const offsetY = initialMousePosition.y - evt.sensorEvent.clientY;
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"version": "1.0.0-beta.14",
"private": false,
"license": "MIT",
"type": "module",
"description": "The JavaScript Drag & Drop library your grand-grandparents warned you about.",
"author": "Henrique <[email protected]>",
"homepage": "https://github.com/hnrq/draggable#readme",
Expand Down Expand Up @@ -59,6 +58,7 @@
"@testing-library/dom": "^8.17.1",
"@testing-library/jest-dom": "^5.16.5",
"@types/jest": "^28.1.6",
"@types/testing-library__jest-dom": "^5.14.5",
"@typescript-eslint/eslint-plugin": "^5.33.0",
"@typescript-eslint/parser": "^5.33.0",
"codecov": "^3.8.2",
Expand Down
2 changes: 2 additions & 0 deletions pnpm-lock.yaml
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

141 changes: 113 additions & 28 deletions src/Draggable/DragEvent/index.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,18 @@ describe('DragEvent', () => {

it('initializes with source', () => {
const source = document.createElement('h1');
const event = new DragEvent({ source });
const event = new DragEvent({ detail: { source } });

expect(event.source).toBe(source);
});

it('initializes with mirror', () => {
const mirror = document.createElement('div');
const event = new DragEvent({
mirror,
source: document.createElement('div'),
detail: {
mirror,
source: document.createElement('div'),
},
});

expect(event.mirror).toBe(mirror);
Expand All @@ -46,8 +48,10 @@ describe('DragEvent', () => {
it('initializes with sourceContainer', () => {
const sourceContainer = document.createElement('div');
const event = new DragEvent({
sourceContainer,
source: document.createElement('div'),
detail: {
sourceContainer,
source: document.createElement('div'),
},
});

expect(event.sourceContainer).toBe(sourceContainer);
Expand All @@ -56,8 +60,10 @@ describe('DragEvent', () => {
it('initializes with sensorEvent', () => {
const sensorEvent = new SensorEvent();
const event = new DragEvent({
sensorEvent,
source: document.createElement('div'),
detail: {
sensorEvent,
source: document.createElement('div'),
},
});

expect(event.sensorEvent).toBe(sensorEvent);
Expand All @@ -66,8 +72,12 @@ describe('DragEvent', () => {
it('initializes with originalEvent', () => {
const originalEvent = new Event('drag');
const event = new DragEvent({
sensorEvent: new SensorEvent({ originalEvent } as SensorEvent),
source: document.createElement('div'),
detail: {
sensorEvent: new SensorEvent({
detail: { originalEvent },
} as SensorEvent),
source: document.createElement('div'),
},
});

expect(event.originalEvent).toBe(originalEvent);
Expand All @@ -76,7 +86,10 @@ describe('DragEvent', () => {

describe('#originalEvent', () => {
it('returns null when initialized without sensorEvent', () => {
const event = new DragEvent({ source: document.createElement('div') });
const event = new DragEvent(
{ detail: { source: document.createElement('div') } },
DragEvent.type
);

expect(event.originalEvent).toBeNull();
});
Expand All @@ -86,13 +99,23 @@ describe('DragEvent', () => {
describe('DragStartEvent', () => {
describe('#constructor', () => {
it('is instance of DragStartEvent', () => {
const event = new DragStartEvent();
const event = new DragStartEvent({
source: document.createElement('div'),
originalSource: document.createElement('div'),
sourceContainer: document.createElement('div'),
sensorEvent: new SensorEvent(),
});

expect(event).toBeInstanceOf(DragStartEvent);
});

it('initializes with `type` of `drag:start`', () => {
const event = new DragStartEvent();
const event = new DragStartEvent({
source: document.createElement('div'),
originalSource: document.createElement('div'),
sourceContainer: document.createElement('div'),
sensorEvent: new SensorEvent(),
});

expect(event.type).toBe('drag:start');
});
Expand All @@ -102,13 +125,17 @@ describe('DragStartEvent', () => {
describe('DragMoveEvent', () => {
describe('#constructor', () => {
it('is instance of DragMoveEvent', () => {
const event = new DragMoveEvent();
const event = new DragMoveEvent({
source: document.createElement('div'),
});

expect(event).toBeInstanceOf(DragMoveEvent);
});

it('initializes with `type` of `drag:move`', () => {
const event = new DragMoveEvent();
const event = new DragMoveEvent({
source: document.createElement('div'),
});

expect(event.type).toBe('drag:move');
});
Expand All @@ -118,13 +145,19 @@ describe('DragMoveEvent', () => {
describe('DragOutContainerEvent', () => {
describe('#constructor', () => {
it('is instance of DragOutContainerEvent', () => {
const event = new DragOutContainerEvent();
const event = new DragOutContainerEvent({
source: document.createElement('div'),
overContainer: document.createElement('div'),
});

expect(event).toBeInstanceOf(DragOutContainerEvent);
});

it('initializes with `type` of `drag:out:container`', () => {
const event = new DragOutContainerEvent();
const event = new DragOutContainerEvent({
source: document.createElement('div'),
overContainer: document.createElement('div'),
});

expect(event.type).toBe('drag:out:container');
});
Expand All @@ -144,20 +177,30 @@ describe('DragOutContainerEvent', () => {
describe('DragOutEvent', () => {
describe('#constructor', () => {
it('is instance of DragOutEvent', () => {
const event = new DragOutEvent();
const event = new DragOutEvent({
source: document.createElement('div'),
overContainer: document.createElement('div'),
over: document.createElement('div'),
});

expect(event).toBeInstanceOf(DragOutEvent);
});

it('initializes with `type` of `drag:out`', () => {
const event = new DragOutEvent();
const event = new DragOutEvent({
source: document.createElement('div'),
overContainer: document.createElement('div'),
over: document.createElement('div'),
});

expect(event.type).toBe('drag:out');
});

it('initializes with overContainer', () => {
const over = document.createElement('div');
const overContainer = document.createElement('div');
const event = new DragOutEvent({
over,
overContainer,
source: document.createElement('div'),
});
Expand All @@ -167,8 +210,10 @@ describe('DragOutEvent', () => {

it('initializes with over', () => {
const over = document.createElement('div');
const overContainer = document.createElement('div');
const event = new DragOutEvent({
over,
overContainer,
source: document.createElement('div'),
});

Expand All @@ -180,20 +225,30 @@ describe('DragOutEvent', () => {
describe('DragOverContainerEvent', () => {
describe('#constructor', () => {
it('is instance of DragOverContainerEvent', () => {
const event = new DragOverContainerEvent();
const event = new DragOverContainerEvent({
over: document.createElement('div'),
overContainer: document.createElement('div'),
source: document.createElement('div'),
});

expect(event).toBeInstanceOf(DragOverContainerEvent);
});

it('initializes with `type` of `drag:over:container`', () => {
const event = new DragOverContainerEvent();
const event = new DragOverContainerEvent({
over: document.createElement('div'),
overContainer: document.createElement('div'),
source: document.createElement('div'),
});

expect(event.type).toBe('drag:over:container');
});

it('initializes with overContainer', () => {
const over = document.createElement('div');
const overContainer = document.createElement('div');
const event = new DragOverContainerEvent({
over,
overContainer,
source: document.createElement('div'),
});
Expand All @@ -206,20 +261,30 @@ describe('DragOverContainerEvent', () => {
describe('DragOverEvent', () => {
describe('#constructor', () => {
it('is instance of DragOverEvent', () => {
const event = new DragOverEvent();
const event = new DragOverEvent({
over: document.createElement('div'),
source: document.createElement('div'),
overContainer: document.createElement('div'),
});

expect(event).toBeInstanceOf(DragOverEvent);
});

it('initializes with `type` of `drag:over`', () => {
const event = new DragOverEvent();
const event = new DragOverEvent({
over: document.createElement('div'),
source: document.createElement('div'),
overContainer: document.createElement('div'),
});

expect(event.type).toBe('drag:over');
});

it('initializes with overContainer', () => {
const over = document.createElement('div');
const overContainer = document.createElement('div');
const event = new DragOverEvent({
over,
overContainer,
source: document.createElement('div'),
});
Expand All @@ -229,8 +294,10 @@ describe('DragOverEvent', () => {

it('initializes with over', () => {
const over = document.createElement('div');
const overContainer = document.createElement('div');
const event = new DragOverEvent({
over,
overContainer,
source: document.createElement('div'),
});

Expand All @@ -242,13 +309,19 @@ describe('DragOverEvent', () => {
describe('DragPressureEvent', () => {
describe('#constructor', () => {
it('is instance of DragPressureEvent', () => {
const event = new DragPressureEvent();
const event = new DragPressureEvent({
pressure: 4,
source: document.createElement('div'),
});

expect(event).toBeInstanceOf(DragPressureEvent);
});

it('initializes with `type` of `drag:pressure`', () => {
const event = new DragPressureEvent();
const event = new DragPressureEvent({
pressure: 4,
source: document.createElement('div'),
});

expect(event.type).toBe('drag:pressure');
});
Expand All @@ -268,13 +341,21 @@ describe('DragPressureEvent', () => {
describe('DragStopEvent', () => {
describe('#constructor', () => {
it('is instance of DragStopEvent', () => {
const event = new DragStopEvent();
const event = new DragStopEvent({
source: document.createElement('div'),
sourceContainer: document.createElement('div'),
originalSource: document.createElement('div'),
});

expect(event).toBeInstanceOf(DragStopEvent);
});

it('initializes with `type` of `drag:stop`', () => {
const event = new DragStopEvent();
const event = new DragStopEvent({
source: document.createElement('div'),
sourceContainer: document.createElement('div'),
originalSource: document.createElement('div'),
});

expect(event.type).toBe('drag:stop');
});
Expand All @@ -284,13 +365,17 @@ describe('DragStopEvent', () => {
describe('DragStoppedEvent', () => {
describe('#constructor', () => {
it('is instance of DragStoppedEvent', () => {
const event = new DragStoppedEvent();
const event = new DragStoppedEvent({
source: document.createElement('div'),
});

expect(event).toBeInstanceOf(DragStoppedEvent);
});

it('initializes with `type` of `drag:stopped`', () => {
const event = new DragStoppedEvent();
const event = new DragStoppedEvent({
source: document.createElement('div'),
});

expect(event.type).toBe('drag:stopped');
});
Expand Down
Loading

0 comments on commit 5c5b3a1

Please sign in to comment.