Merge pull request janhq#935 from janhq/fix/inference_model_parameters

fix: model parameters for inference extensions
hokhyk · Dec 11, 2023 · 79b9997 · 79b9997
2 parents c4d8def + 97f3733
commit 79b9997
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 11 deletions.
diff --git a/extensions/inference-nitro-extension/src/helpers/sse.ts b/extensions/inference-nitro-extension/src/helpers/sse.ts
@@ -16,7 +16,7 @@ export function requestInference(
       messages: recentMessages,
       model: model.id,
       stream: true,
-      // ...model.parameters,
+      ...model.parameters,
     });
     fetch(INFERENCE_URL, {
       method: "POST",

diff --git a/extensions/inference-openai-extension/src/helpers/sse.ts b/extensions/inference-openai-extension/src/helpers/sse.ts
@@ -22,8 +22,8 @@ export function requestInference(
     const requestBody = JSON.stringify({
       messages: recentMessages,
       stream: true,
-      model: model_id
-      // ...model.parameters,
+      model: model_id,
+      ...model.parameters,
     });
     fetch(`${engine.full_url}`, {
       method: "POST",

diff --git a/models/gpt-3.5-turbo-16k-0613/model.json b/models/gpt-3.5-turbo-16k-0613/model.json
@@ -7,9 +7,7 @@
     "description": "OpenAI GPT 3.5 Turbo 16k 0613 model is extremely good",
     "format": "api",
     "settings": {},
-    "parameters": {
-      "max_tokens": 4096
-    },
+    "parameters": {},
     "metadata": {
       "author": "OpenAI",
       "tags": ["General", "Big Context Length"]

diff --git a/models/gpt-4/model.json b/models/gpt-4/model.json
@@ -2,14 +2,12 @@
     "source_url": "https://openai.com",
     "id": "gpt-4",
     "object": "model",
-    "name": "OpenAI GPT 3.5",
+    "name": "OpenAI GPT 4",
     "version": 1.0,
-    "description": "OpenAI GPT 3.5 model is extremely good",
+    "description": "OpenAI GPT 4 model is extremely good",
     "format": "api",
     "settings": {},
-    "parameters": {
-      "max_tokens": 4096
-    },
+    "parameters": {},
     "metadata": {
       "author": "OpenAI",
       "tags": ["General", "Big Context Length"]