Skip to content
This repository has been archived by the owner on Nov 24, 2021. It is now read-only.

Improve infocus ui #15

Merged
merged 10 commits into from
Apr 4, 2018
Merged

Improve infocus ui #15

merged 10 commits into from
Apr 4, 2018

Conversation

hollanderbart
Copy link
Owner

This will resolve the #14 bug and will improve the user experience. It will now only show a previous of the channel when it is in focus.

@hollanderbart
Copy link
Owner Author

also resolved #12

@hollanderbart hollanderbart merged commit 40fcef1 into master Apr 4, 2018
@FokkeZB
Copy link

FokkeZB commented Apr 4, 2018

@hollanderbart thanks!

I gave this a try, but ran into:

dyld: Library not loaded: @rpath/NPOStream.framework/NPOStream
  Referenced from: /var/containers/Bundle/Application/945A8861-027C-402D-AE27-50742B7120D5/NPO Live.app/NPO Live
  Reason: no suitable image found.  Did find:
	/private/var/containers/Bundle/Application/945A8861-027C-402D-AE27-50742B7120D5/NPO Live.app/Frameworks/NPOStream.framework/NPOStream: required code signature missing for '/private/var/containers/Bundle/Application/945A8861-027C-402D-AE27-50742B7120D5/NPO Live.app/Frameworks/NPOStream.framework/NPOStream'

	/private/var/containers/Bundle/Application/945A8861-027C-402D-AE27-50742B7120D5/NPO Live.app/Frameworks/NPOStream.framework/NPOStream: required code signature missing for '/private/var/containers/Bundle/Application/945A8861-027C-402D-AE27-50742B7120D5/NPO Live.app/Frameworks/NPOStream.framework/NPOStream'

	/private/var/containers/Bundle/Application/945A8861-027C-402D-AE27-50742B7120D5/NPO Live.app/Frameworks/NPOStream.framework/NPOStream: required code signature missing for '/private/var/containers/Bundle/Application/945A8861-027C-402D-AE27-50742B7120D5/NPO Live.app/Frameworks/NPOStream.framework/NPOStream'

I did run pod install. I'm on Xcode 9.3 and run tvOS 11.3.

@FokkeZB
Copy link

FokkeZB commented Apr 4, 2018

I fixed it by setting this setting:

@hollanderbart
Copy link
Owner Author

Ok, I will fix that. Thanks for mentioning FokkeZB. Much appreciated!!
But the big question is, does it work better now?

@FokkeZB
Copy link

FokkeZB commented Apr 4, 2018

It does! I did notice some lag when going through the menu. Perhaps there should be some delay before loading the stream to prevent that?

@hollanderbart
Copy link
Owner Author

Needs a lot more testing though. I’m looking for users who are willing to test this before I want to release a next version.

@hollanderbart
Copy link
Owner Author

Good point. I was already thinking about this as a possible solution. But it already avoids the loading spinner screens by only presenting the preview when the video buffer is full. Maybe I can check/verify if the video buffering is done on the background.

@hollanderbart hollanderbart deleted the improve-infocus-ui branch April 4, 2018 20:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants