Rubocop: Fix Lint/ParenthesesAsGroupedExpression

.rubocop_todo.yml

@@ -11,14 +11,6 @@ Lint/HandleExceptions:
   Exclude:
     - 'lib/puppet/jenkins/plugins.rb'
 
-# Offense count: 14
-Lint/ParenthesesAsGroupedExpression:
-  Exclude:
-    - 'spec/classes/jenkins_direct_download_spec.rb'
-    - 'spec/classes/jenkins_spec.rb'
-    - 'spec/defines/jenkins_augeas_spec.rb'
-    - 'spec/unit/jenkins_plugins_spec.rb'
-
 # Offense count: 1
 Lint/UselessAssignment:
   Exclude:

spec/classes/jenkins_direct_download_spec.rb

@@ -40,14 +40,14 @@
     end
 
     context 'package removable' do
-      let (:params) { { version: 'absent', direct_download: 'http://local.space/jenkins.rpm' } }
+      let(:params) { { version: 'absent', direct_download: 'http://local.space/jenkins.rpm' } }
 
       it { is_expected.not_to contain_staging__file('jenkins.rpm') }
       it { is_expected.to contain_package('jenkins').with_ensure('absent') }
     end
 
     context 'unsupported provider fails' do
-      let (:params) { { package_provider: false, direct_download: 'http://local.space/jenkins.rpm' } }
+      let(:params) { { package_provider: false, direct_download: 'http://local.space/jenkins.rpm' } }
 
       it do
         expect { is_expected.to compile }.to raise_error(RSpec::Expectations::ExpectationNotMetError, %r{error during compilation})

spec/classes/jenkins_spec.rb

@@ -286,7 +286,7 @@
     end
 
     describe 'with default plugins override' do
-      let (:params) { { default_plugins: [] } }
+      let(:params) { { default_plugins: [] } }
 
       it { is_expected.not_to contain_jenkins__plugin 'credentials' }
     end

spec/defines/jenkins_augeas_spec.rb

@@ -20,7 +20,7 @@
 
   [false].each do |pval|
     describe "with plugin param #{pval} (#{pval.class})" do
-      let (:params) { { config_filename: 'foo.xml', changes: ['set foo bar'], plugin: pval } }
+      let(:params) { { config_filename: 'foo.xml', changes: ['set foo bar'], plugin: pval } }
 
       it do
         is_expected.to contain_augeas('jenkins::augeas: myplug').with(
@@ -36,7 +36,7 @@
 
   [true].each do |pval|
     describe "with plugin param #{pval} (#{pval.class})" do
-      let (:params) { { config_filename: 'foo.xml', changes: ['set foo bar'], plugin: pval } }
+      let(:params) { { config_filename: 'foo.xml', changes: ['set foo bar'], plugin: pval } }
 
       it do
         is_expected.to contain_jenkins__plugin('myplug')
@@ -45,7 +45,7 @@
   end
 
   describe "with plugin param 'pluginname'" do
-    let (:params) { { config_filename: 'foo.xml', changes: ['set foo bar'], plugin: 'pluginname' } }
+    let(:params) { { config_filename: 'foo.xml', changes: ['set foo bar'], plugin: 'pluginname' } }
 
     it do
       is_expected.to contain_jenkins__plugin('pluginname')
@@ -60,7 +60,7 @@
   # |              `---'      ---                                    |
 
   describe 'with plugin_version set' do
-    let (:params) do
+    let(:params) do
       {
         config_filename: 'foo.xml',
         changes: [],
@@ -84,7 +84,7 @@
   # `---'`---'`   '`---'`---''  ``---'    |---'`---^`    `---^` ' '
   #                                       |
   describe 'without context set' do
-    let (:params) do
+    let(:params) do
       {
         plugin: false,
         config_filename: 'foo.xml',
@@ -102,7 +102,7 @@
   end
 
   describe 'with context set' do
-    let (:params) do
+    let(:params) do
       {
         plugin: false,
         config_filename: 'foo.xml',
@@ -129,7 +129,7 @@
 
   [['get foo != bar'], 'get foo != bar'].each do |pval|
     describe "with param onlyif set and class is #{pval.class}" do
-      let (:params) do
+      let(:params) do
         {
           plugin: false,
           config_filename: 'foo.xml',
@@ -157,7 +157,7 @@
   #                     `---'              |
   [['set foo bar'], 'set foo bar'].each do |pval|
     describe "with param changes set and class is #{pval.class}" do
-      let (:params) do
+      let(:params) do
         {
           plugin: false,
           config_filename: 'foo.xml',
@@ -185,7 +185,7 @@
     false   => 'reload-jenkins'
   }.each do |pval, expected|
     describe "with param restart set to '#{pval}' (#{pval.class})" do
-      let (:params) do
+      let(:params) do
         {
           plugin: false,
           config_filename: 'foo.xml',

spec/unit/jenkins_plugins_spec.rb

@@ -144,7 +144,7 @@
     context 'uses json' do
       it { is_expected.to be_instance_of Hash }
       it { is_expected.to have_key('AdaptivePlugin') }
-      its (:size) { is_expected.to be 1 }
+      its(:size) { is_expected.to be 1 }
     end
 
     context 'uses okjson when json is not avaliable' do
@@ -155,7 +155,7 @@
 
       it { is_expected.to be_instance_of Hash }
       it { is_expected.to have_key('AdaptivePlugin') }
-      its (:size) { is_expected.to be 1 }
+      its(:size) { is_expected.to be 1 }
     end
   end