Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use !!v insetead of Boolean(v) to reduce bundle size #3708

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EdamAme-x
Copy link
Contributor

@EdamAme-x EdamAme-x commented Nov 28, 2024

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@EdamAme-x EdamAme-x marked this pull request as draft November 28, 2024 03:29
@EdamAme-x
Copy link
Contributor Author

I don't know why to failed tests

The types of result seems to be Promise<string> | undefined...?
https://github.com/honojs/hono/blob/55cec8b522f4eac1636e03511c3683f7f04f9f47/src/utils/html.ts#L16

@yusukebe
Copy link
Member

@EdamAme-x

If this is ready for review, please ping me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants