fix(middleware/cors): explicitly return No Content for the statusText when handling an OPTIONS request #3719
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
cors
middleware processes anOPTIONS
request by default, it returns the response status text from the context,c.res.statusText
. However, in most cases, the middleware is executed before any routes or other middlewares that could modify the responsestatusText
, leading to aNot Found
response status. To align with the explicit204
being returned, the response should also includeNo Content
, similar to how theetag
middleware handles setting thestatusText
toNot Modified
.The author should do the following, if applicable
bun run format:fix && bun run lint:fix
to format the code