Modify js prototype and add node snippets #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honza
added a commit
that referenced
this pull request
Aug 20, 2014
Modify js prototype and add node snippets
|
✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rarely see any js code where the function being added to the prototype is on a new line so I moved it to the same one.
I've also added node snippets that cover very common actions such as requiring modules or exporting from a module. I decided to leave out most callbacks from the snippets because they can be created by tabbing through until the
handlerand using thefsnippet to create a new anonymous function.It's nitpicking but I've also removed the spaces before the braces in anonymous functions as this seems to be a convention adopted by the js community. See here and here.