fix: remove trailing ? from the url when no params are present (#291)

hoppscotch · Apr 22, 2024 · 1e46a1f · 1e46a1f
1 parent 6227ecd
commit 1e46a1f
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/manifest.common.json b/manifest.common.json
@@ -1,7 +1,7 @@
 {
   "manifest_version": 3,
   "name": "Hoppscotch Browser Extension",
-  "version": "0.33",
+  "version": "0.34",
   "description": "Provides more capabilities for Hoppscotch",
   "icons": {
     "16": "icons/icon-16x16.png",

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "hoppscotch-extension",
-  "version": "0.33.0",
+  "version": "0.34.0",
   "description": "Provides more features to the Hoppscotch webapp (https://hoppscotch.io/)",
   "scripts": {
     "clean": "rimraf dist .parcel-cache",

diff --git a/src/hookContent.js b/src/hookContent.js
@@ -36,7 +36,7 @@
   }
 
   window.__POSTWOMAN_EXTENSION_HOOK__ = {
-    getVersion: () => ({ major: 0, minor: 33 }),
+    getVersion: () => ({ major: 0, minor: 34 }),
 
     decodeB64ToArrayBuffer: (input, ab) => {
       const keyStr =

diff --git a/src/index.ts b/src/index.ts
@@ -32,15 +32,15 @@ async function fetchUsingAxiosConfig(
 
   const params = axiosConfig.params
 
-  if (params) {
+  if (params && Object.keys(params).length > 0) {
     try {
-      const searchParams = new URLSearchParams(axiosConfig.url.split("?")[1])
+      const url = new URL(axiosConfig.url)
+
       Object.keys(params).forEach((key) => {
-        searchParams.append(key, params[key])
+        url.searchParams.append(key, params[key])
       })
 
-      axiosConfig.url =
-        axiosConfig.url.split("?")[0] + `?${searchParams.toString()}`
+      axiosConfig.url = url.toString()
     } catch (_) {}
   }