Skip to content

Commit

Permalink
[build] pin protobuf-shaded version (apache#2279)
Browse files Browse the repository at this point in the history
### Motivation

shading kills the development experiences in IDEs like intellij.
since protobuf-shaded is a module that is rarely changed, we should
pin the version of `protobuf-shaded` to make IDEs work well with
shaded depenencies

 ### Changes

Pin `protobuf-shaded` to `2.1.0-incubating`
  • Loading branch information
sijie authored Aug 2, 2018
1 parent b7267e6 commit 651d4cd
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 5 deletions.
4 changes: 3 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ flexible messaging model and an intuitive client API.</description>
<module>pulsar-client-kafka-compat</module>
<module>pulsar-zookeeper</module>
<module>pulsar-log4j2-appender</module>
<module>protobuf-shaded</module>
<!-- jclouds shaded for gson conflict: https://issues.apache.org/jira/browse/JCLOUDS-1166 -->
<module>jclouds-shaded</module>

Expand Down Expand Up @@ -127,6 +126,9 @@ flexible messaging model and an intuitive client API.</description>
<testRealAWS>false</testRealAWS>
<testRetryCount>1</testRetryCount>

<!-- pin the protobuf-shaded version to make the pulsar build friendly to intellij -->
<pulsar.protobuf.shaded.version>2.1.0-incubating</pulsar.protobuf.shaded.version>

<!-- apache commons -->
<commons-compress.version>1.15</commons-compress.version>

Expand Down
2 changes: 1 addition & 1 deletion pulsar-broker/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
<dependency>
<groupId>org.apache.pulsar</groupId>
<artifactId>protobuf-shaded</artifactId>
<version>${project.version}</version>
<version>${pulsar.protobuf.shaded.version}</version>
</dependency>

<dependency>
Expand Down
2 changes: 1 addition & 1 deletion pulsar-common/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>protobuf-shaded</artifactId>
<version>${project.version}</version>
<version>${pulsar.protobuf.shaded.version}</version>
<exclusions>
<exclusion>
<groupId>com.google.protobuf</groupId>
Expand Down
2 changes: 1 addition & 1 deletion pulsar-functions/utils/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
<dependency>
<groupId>org.apache.pulsar</groupId>
<artifactId>protobuf-shaded</artifactId>
<version>${project.version}</version>
<version>${pulsar.protobuf.shaded.version}</version>
</dependency>

<dependency>
Expand Down
2 changes: 1 addition & 1 deletion pulsar-io/core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>protobuf-shaded</artifactId>
<version>${project.version}</version>
<version>${pulsar.protobuf.shaded.version}</version>
<exclusions>
<exclusion>
<groupId>com.google.protobuf</groupId>
Expand Down

0 comments on commit 651d4cd

Please sign in to comment.