SAK-41487 Enforce a non empty points value in rubrics (sakaiproject#7836

) https://jira.sakaiproject.org/browse/SAK-41487
hornersa · Jan 31, 2020 · e72de80 · e72de80
1 parent cb3fc0e
commit e72de80
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/rubrics/tool/src/main/frontend/webcomponents/sakai-rubric-criterion-rating-edit.js b/rubrics/tool/src/main/frontend/webcomponents/sakai-rubric-criterion-rating-edit.js
@@ -122,6 +122,10 @@ export class SakaiRubricCriterionRatingEdit extends RubricsElement {
 
     this.rating.title = document.getElementById(`rating-title-${this.rating.id}`).value;
     this.rating.points = document.getElementById(`rating-points-${this.rating.id}`).value;
+
+    // Enforce a points value. Blank breaks things.
+    if (this.rating.points.length === 0) this.rating.points = "0";
+
     this.rating.description = document.getElementById(`rating-description-${this.rating.id}`).value;
     this.rating.criterionId = this.criterionId;