Skip to content

Commit

Permalink
Remove unnecessary env variables (istio#632)
Browse files Browse the repository at this point in the history
* Remove unnecessary env variables

* update goldens
  • Loading branch information
richardwxn authored and istio-testing committed Nov 27, 2019
1 parent 4d8b891 commit 0c33028
Showing 7 changed files with 11 additions and 19 deletions.
2 changes: 1 addition & 1 deletion cmd/mesh/testdata/manifest-generate/output/all_on.yaml

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

6 changes: 2 additions & 4 deletions cmd/mesh/testdata/profile-dump/output/all_off.yaml
Original file line number Diff line number Diff line change
@@ -180,10 +180,6 @@ trafficManagement:
fieldRef:
apiVersion: v1
fieldPath: metadata.namespace
- name: PILOT_TRACE_SAMPLING
value: "1"
- name: CONFIG_NAMESPACE
value: istio-config
hpaSpec:
maxReplicas: 5
metrics:
@@ -546,6 +542,8 @@ values:
sessionAffinityEnabled: false
telemetry:
autoscaleEnabled: true
env:
GOMAXPROCS: "6"
image: mixer
loadshedding:
latencyThreshold: 100ms
6 changes: 2 additions & 4 deletions cmd/mesh/testdata/profile-dump/output/sds_policy_off.yaml
Original file line number Diff line number Diff line change
@@ -180,10 +180,6 @@ trafficManagement:
fieldRef:
apiVersion: v1
fieldPath: metadata.namespace
- name: PILOT_TRACE_SAMPLING
value: "1"
- name: CONFIG_NAMESPACE
value: istio-config
hpaSpec:
maxReplicas: 5
metrics:
@@ -546,6 +542,8 @@ values:
sessionAffinityEnabled: false
telemetry:
autoscaleEnabled: true
env:
GOMAXPROCS: "6"
image: mixer
loadshedding:
latencyThreshold: 100ms
6 changes: 2 additions & 4 deletions data/profiles/default.yaml
Original file line number Diff line number Diff line change
@@ -23,10 +23,6 @@ spec:
fieldRef:
apiVersion: v1
fieldPath: metadata.namespace
- name: PILOT_TRACE_SAMPLING
value: "1"
- name: CONFIG_NAMESPACE
value: istio-config
hpaSpec:
maxReplicas: 5
minReplicas: 1
@@ -428,6 +424,8 @@ spec:
reportBatchMaxEntries: 100
reportBatchMaxTime: 1s
useMCP: true
env:
GOMAXPROCS: "6"
nodeSelector: {}
tolerations: []
podAntiAffinityLabelSelector: []
6 changes: 2 additions & 4 deletions pkg/vfs/assets.gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 0c33028

Please sign in to comment.