Skip to content

Commit

Permalink
Implement operator< for KeyOriginInfo and CExtPubKey
Browse files Browse the repository at this point in the history
  • Loading branch information
achow101 committed Dec 10, 2021
1 parent d3dbb16 commit c5c63b8
Show file tree
Hide file tree
Showing 2 changed files with 34 additions and 0 deletions.
15 changes: 15 additions & 0 deletions src/pubkey.h
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,11 @@ class CPubKey
return a.vch[0] < b.vch[0] ||
(a.vch[0] == b.vch[0] && memcmp(a.vch, b.vch, a.size()) < 0);
}
friend bool operator>(const CPubKey& a, const CPubKey& b)
{
return a.vch[0] > b.vch[0] ||
(a.vch[0] == b.vch[0] && memcmp(a.vch, b.vch, a.size()) > 0);
}

//! Implement serialization, as if this was a byte vector.
template <typename Stream>
Expand Down Expand Up @@ -305,6 +310,16 @@ struct CExtPubKey {
return !(a == b);
}

friend bool operator<(const CExtPubKey &a, const CExtPubKey &b)
{
if (a.pubkey < b.pubkey) {
return true;
} else if (a.pubkey > b.pubkey) {
return false;
}
return a.chaincode < b.chaincode;
}

void Encode(unsigned char code[BIP32_EXTKEY_SIZE]) const;
void Decode(const unsigned char code[BIP32_EXTKEY_SIZE]);
void EncodeWithVersion(unsigned char code[BIP32_EXTKEY_WITH_VERSION_SIZE]) const;
Expand Down
19 changes: 19 additions & 0 deletions src/script/keyorigin.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,25 @@ struct KeyOriginInfo
return std::equal(std::begin(a.fingerprint), std::end(a.fingerprint), std::begin(b.fingerprint)) && a.path == b.path;
}

friend bool operator<(const KeyOriginInfo& a, const KeyOriginInfo& b)
{
// Compare the fingerprints lexicographically
int fpr_cmp = memcmp(a.fingerprint, b.fingerprint, 4);
if (fpr_cmp < 0) {
return true;
} else if (fpr_cmp > 0) {
return false;
}
// Compare the sizes of the paths, shorter is "less than"
if (a.path.size() < b.path.size()) {
return true;
} else if (a.path.size() > b.path.size()) {
return false;
}
// Paths same length, compare them lexicographically
return a.path < b.path;
}

SERIALIZE_METHODS(KeyOriginInfo, obj) { READWRITE(obj.fingerprint, obj.path); }

void clear()
Expand Down

0 comments on commit c5c63b8

Please sign in to comment.