chore: fix PHPStan

hsoblech · Oct 8, 2021 · f417e08 · f417e08
1 parent da8b941
commit f417e08
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 22 deletions.
diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -86,9 +86,6 @@ parameters:
 			path: tests/GraphQl/Type/TypesContainerTest.php
 
 		# Expected, due to PHP 8 attributes
-		- '#ReflectionProperty::getAttributes\(\)#'
-		- '#ReflectionMethod::getAttributes\(\)#'
-		- '#ReflectionClass<object>::getAttributes\(\)#'
 		- '#Constructor of class ApiPlatform\\Core\\Annotation\\ApiResource has an unused parameter#'
 		- '#Constructor of class ApiPlatform\\Core\\Annotation\\ApiProperty has an unused parameter#'
 

diff --git a/src/Filter/Validator/ArrayItems.php b/src/Filter/Validator/ArrayItems.php
@@ -62,9 +62,12 @@ private function getValue(string $name, array $filterDescription, array $queryPa
 
         $collectionFormat = $filterDescription['swagger']['collectionFormat'] ?? 'csv';
 
-        return explode(self::getSeparator($collectionFormat), $value) ?: [];
+        return explode(self::getSeparator($collectionFormat), $value) ?: []; // @phpstan-ignore-line
     }
 
+    /**
+     * @return non-empty-string
+     */
     private static function getSeparator(string $collectionFormat): string
     {
         switch ($collectionFormat) {

diff --git a/tests/Fixtures/TestBundle/Document/EmbeddedDummy.php b/tests/Fixtures/TestBundle/Document/EmbeddedDummy.php
@@ -33,22 +33,22 @@
 class EmbeddedDummy
 {
     /**
-     * @var int The id
+     * @var int|null The id
      *
      * @ODM\Id(strategy="INCREMENT", type="int")
      */
     private $id;
 
     /**
-     * @var string The dummy name
+     * @var string|null The dummy name
      *
      * @ODM\Field(type="string")
      * @Groups({"embed"})
      */
     private $name;
 
     /**
-     * @var \DateTime A dummy date
+     * @var \DateTime|null A dummy date
      *
      * @ODM\Field(type="date")
      * @Assert\DateTime
@@ -64,13 +64,13 @@ class EmbeddedDummy
     public $embeddedDummy;
 
     /**
-     * @var RelatedDummy A related dummy
+     * @var RelatedDummy|null A related dummy
      *
      * @ODM\ReferenceOne(targetDocument=RelatedDummy::class, storeAs="id")
      */
     public $relatedDummy;
 
-    public static function staticMethod()
+    public static function staticMethod(): void
     {
     }
 
@@ -79,17 +79,17 @@ public function __construct()
         $this->embeddedDummy = new EmbeddableDummy();
     }
 
-    public function getId()
+    public function getId(): ?int
     {
         return $this->id;
     }
 
-    public function getName(): string
+    public function getName(): ?string
     {
         return $this->name;
     }
 
-    public function setName(string $name)
+    public function setName(string $name): void
     {
         $this->name = $name;
     }
@@ -99,27 +99,27 @@ public function getEmbeddedDummy(): EmbeddableDummy
         return $this->embeddedDummy;
     }
 
-    public function setEmbeddedDummy(EmbeddableDummy $embeddedDummy)
+    public function setEmbeddedDummy(EmbeddableDummy $embeddedDummy): void
     {
         $this->embeddedDummy = $embeddedDummy;
     }
 
-    public function getDummyDate(): \DateTime
+    public function getDummyDate(): ?\DateTime
     {
         return $this->dummyDate;
     }
 
-    public function setDummyDate(\DateTime $dummyDate)
+    public function setDummyDate(\DateTime $dummyDate): void
     {
         $this->dummyDate = $dummyDate;
     }
 
-    public function getRelatedDummy(): RelatedDummy
+    public function getRelatedDummy(): ?RelatedDummy
     {
         return $this->relatedDummy;
     }
 
-    public function setRelatedDummy(RelatedDummy $relatedDummy)
+    public function setRelatedDummy(RelatedDummy $relatedDummy): void
     {
         $this->relatedDummy = $relatedDummy;
     }

diff --git a/tests/Fixtures/TestBundle/Document/Question.php b/tests/Fixtures/TestBundle/Document/Question.php
@@ -62,15 +62,13 @@ public function getContent(): string
     /**
      * Get id.
      */
-    public function getId(): ?string
+    public function getId(): ?int
     {
         return $this->id;
     }
 
     /**
      * Set answer.
-     *
-     * @param Answer $answer
      */
     public function setAnswer(Answer $answer = null): self
     {
@@ -82,7 +80,7 @@ public function setAnswer(Answer $answer = null): self
     /**
      * Get answer.
      */
-    public function getAnswer(): Answer
+    public function getAnswer(): ?Answer
     {
         return $this->answer;
     }

diff --git a/tests/Fixtures/TestBundle/Document/RelatedNormalizedDummy.php b/tests/Fixtures/TestBundle/Document/RelatedNormalizedDummy.php
@@ -53,7 +53,7 @@ class RelatedNormalizedDummy
     private $name;
 
     /**
-     * @var ArrayCollection Several Normalized dummies
+     * @var Collection Several Normalized dummies
      *
      * @ODM\ReferenceMany(targetDocument=CustomNormalizedDummy::class)
      * @Groups({"related_output", "related_input"})