Skip to content

Commit

Permalink
net: dsa: use NET_NAME_PREDICTABLE for user ports with name given in DT
Browse files Browse the repository at this point in the history
When a user port has a label in device tree, the corresponding
netdevice is, to quote include/uapi/linux/netdevice.h, "predictably
named by the kernel". This is also explicitly one of the intended use
cases for NET_NAME_PREDICTABLE, quoting 685343f ("net: add
name_assign_type netdev attribute"):

  NET_NAME_PREDICTABLE:
    The ifname has been assigned by the kernel in a predictable way
    [...] Examples include [...] and names deduced from hardware
    properties (including being given explicitly by the firmware).

Expose that information properly for the benefit of userspace tools
that make decisions based on the name_assign_type attribute,
e.g. a systemd-udev rule with "kernel" in NamePolicy.

Signed-off-by: Rasmus Villemoes <[email protected]>
Reviewed-by: Andrew Lunn <[email protected]>
Reviewed-by: Florian Fainelli <[email protected]>
Signed-off-by: Jakub Kicinski <[email protected]>
  • Loading branch information
Villemoes authored and kuba-moo committed Nov 18, 2022
1 parent 0171a1d commit 6fdb038
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/dsa/slave.c
Original file line number Diff line number Diff line change
Expand Up @@ -2377,7 +2377,7 @@ int dsa_slave_create(struct dsa_port *port)

if (port->name) {
name = port->name;
assign_type = NET_NAME_UNKNOWN;
assign_type = NET_NAME_PREDICTABLE;
} else {
name = "eth%d";
assign_type = NET_NAME_UNKNOWN;
Expand Down

0 comments on commit 6fdb038

Please sign in to comment.