Update/sync add feature flag use rest api for sending (Automattic#36118)

* Sync: Add feature flag for using rest api for sync * add changelog * Added into sync settings and created method to check if it is enabled or not * Changelog * Change names of the option to sync to wpcom_rest_api_enabled * Updated the comments after changing names of variable * Update projects/packages/sync/src/class-settings.php Co-authored-by: Foteini Giannaropoulou <[email protected]> * Fixed spacing --------- Co-authored-by: Foteini Giannaropoulou <[email protected]>
https-madcitymultimedia-vhx-tv-products · Mar 4, 2024 · 1adad87 · 1adad87
1 parent 4471fce
commit 1adad87
Show file tree

Hide file tree

Showing 16 changed files with 81 additions and 0 deletions.
diff --git a/projects/packages/sync/changelog/update-sync-add-feature-flag-use-rest-api-for-sending b/projects/packages/sync/changelog/update-sync-add-feature-flag-use-rest-api-for-sending
@@ -0,0 +1,4 @@
+Significance: minor
+Type: added
+
+Sync: Add feature flag for enabling the use of rest api for sending the sync data 
diff --git a/projects/packages/sync/src/class-data-settings.php b/projects/packages/sync/src/class-data-settings.php
@@ -69,6 +69,7 @@ class Data_Settings {
 			'jetpack_sync_settings_taxonomies_blacklist',
 			'jetpack_sync_settings_dedicated_sync_enabled',
 			'jetpack_sync_settings_custom_queue_table_enabled',
+			'jetpack_sync_settings_wpcom_rest_api_enabled',
 			/**
 			 * Connection related options
 			 */

diff --git a/projects/packages/sync/src/class-defaults.php b/projects/packages/sync/src/class-defaults.php
@@ -100,6 +100,7 @@ class Defaults {
 		'jetpack_sync_settings_taxonomies_blacklist',
 		'jetpack_sync_settings_dedicated_sync_enabled', // is Dedicated Sync flow enabled.
 		'jetpack_sync_settings_custom_queue_table_enabled', // is custom queue table enabled.
+		'jetpack_sync_settings_wpcom_rest_api_enabled', // is wpcom rest api enabled.
 		'jetpack_testimonial',
 		'jetpack_testimonial_posts_per_page',
 		'jetpack_wga',
@@ -1324,4 +1325,11 @@ public static function is_multi_network() {
 	 * @var int Bool-ish. Default 0.
 	 */
 	public static $default_custom_queue_table_enabled = 0;
+
+	/**
+	 * Default for enabling wpcom rest api for Sync.
+	 *
+	 * @var int Bool-ish. Default 0.
+	 */
+	public static $default_wpcom_rest_api_enabled = 0;
 }
diff --git a/projects/packages/sync/src/class-settings.php b/projects/packages/sync/src/class-settings.php
@@ -61,6 +61,7 @@ class Settings {
 		'checksum_disable'                       => true,
 		'dedicated_sync_enabled'                 => true,
 		'custom_queue_table_enabled'             => true,
+		'wpcom_rest_api_enabled'                 => true,
 	);
 
 	/**
@@ -678,4 +679,16 @@ public static function is_dedicated_sync_enabled() {
 	public static function is_custom_queue_table_enabled() {
 		return (bool) self::get_setting( 'custom_queue_table_enabled' );
 	}
+
+	/**
+	 * Whether wpcom rest api is enabled.
+	 *
+	 * @access public
+	 * @static
+	 *
+	 * @return boolean Whether wpcom rest api is enabled.
+	 */
+	public static function is_wpcom_rest_api_enabled() {
+		return (bool) self::get_setting( 'wpcom_rest_api_enabled' );
+	}
 }
diff --git a/projects/packages/sync/tests/php/data-test-data-settings.php b/projects/packages/sync/tests/php/data-test-data-settings.php
@@ -233,6 +233,7 @@ public static function data_test_3() {
 					'jetpack_sync_settings_taxonomies_blacklist',
 					'jetpack_sync_settings_dedicated_sync_enabled',
 					'jetpack_sync_settings_custom_queue_table_enabled',
+					'jetpack_sync_settings_wpcom_rest_api_enabled',
 					'jetpack_connection_active_plugins',
 					'jetpack_package_versions',
 					'blog_charset',
@@ -521,6 +522,7 @@ public static function data_test_7() {
 					'jetpack_sync_settings_taxonomies_blacklist',
 					'jetpack_sync_settings_dedicated_sync_enabled',
 					'jetpack_sync_settings_custom_queue_table_enabled',
+					'jetpack_sync_settings_wpcom_rest_api_enabled',
 					'jetpack_connection_active_plugins',
 					'jetpack_package_versions',
 					'blog_charset',
@@ -574,6 +576,7 @@ public static function data_test_7_1() {
 					'jetpack_sync_settings_taxonomies_blacklist',
 					'jetpack_sync_settings_dedicated_sync_enabled',
 					'jetpack_sync_settings_custom_queue_table_enabled',
+					'jetpack_sync_settings_wpcom_rest_api_enabled',
 					'jetpack_connection_active_plugins',
 					'jetpack_package_versions',
 					'blog_charset',
@@ -630,6 +633,7 @@ public static function data_test_7_2() {
 					'jetpack_sync_settings_taxonomies_blacklist',
 					'jetpack_sync_settings_dedicated_sync_enabled',
 					'jetpack_sync_settings_custom_queue_table_enabled',
+					'jetpack_sync_settings_wpcom_rest_api_enabled',
 					'jetpack_connection_active_plugins',
 					'jetpack_package_versions',
 					'blog_charset',
@@ -866,6 +870,7 @@ public static function data_test_10() {
 					'jetpack_sync_settings_taxonomies_blacklist',
 					'jetpack_sync_settings_dedicated_sync_enabled',
 					'jetpack_sync_settings_custom_queue_table_enabled',
+					'jetpack_sync_settings_wpcom_rest_api_enabled',
 					'jetpack_connection_active_plugins',
 					'jetpack_package_versions',
 					'blog_charset',

diff --git a/projects/plugins/backup/changelog/update-sync-add-feature-flag-use-rest-api-for-sending b/projects/plugins/backup/changelog/update-sync-add-feature-flag-use-rest-api-for-sending
@@ -0,0 +1,5 @@
+Significance: patch
+Type: changed
+Comment: Updated composer.lock.
+
+
diff --git a/projects/plugins/boost/changelog/update-sync-add-feature-flag-use-rest-api-for-sending b/projects/plugins/boost/changelog/update-sync-add-feature-flag-use-rest-api-for-sending
@@ -0,0 +1,5 @@
+Significance: patch
+Type: changed
+Comment: Updated composer.lock.
+
+
diff --git a/projects/plugins/jetpack/changelog/update-sync-add-feature-flag-use-rest-api-for-sending b/projects/plugins/jetpack/changelog/update-sync-add-feature-flag-use-rest-api-for-sending
@@ -0,0 +1,4 @@
+Significance: minor
+Type: other
+
+Sync:Add feature flag for enabling the use of rest api for sending the sync data
diff --git a/projects/plugins/jetpack/changelog/update-sync-add-feature-flag-use-rest-api-for-sending#2 b/projects/plugins/jetpack/changelog/update-sync-add-feature-flag-use-rest-api-for-sending#2
@@ -0,0 +1,5 @@
+Significance: patch
+Type: other
+Comment: Updated composer.lock.
+
+
diff --git a/projects/plugins/jetpack/tests/php/sync/test_class.jetpack-sync-options.php b/projects/plugins/jetpack/tests/php/sync/test_class.jetpack-sync-options.php
@@ -225,6 +225,7 @@ public function test_sync_default_options() {
 			'jetpack_sync_non_blocking'                    => false,
 			'jetpack_sync_settings_dedicated_sync_enabled' => false,
 			'jetpack_sync_settings_custom_queue_table_enabled' => false,
+			'jetpack_sync_settings_wpcom_rest_api_enabled' => false,
 			'jetpack_sync_settings_comment_meta_whitelist' => array( 'jetpack', 'pineapple' ),
 			'jetpack_sync_settings_post_meta_whitelist'    => array( 'jetpack', 'pineapple' ),
 			'jetpack_sync_settings_post_types_blacklist'   => array( 'jetpack', 'pineapple' ),

diff --git a/projects/plugins/migration/changelog/update-sync-add-feature-flag-use-rest-api-for-sending b/projects/plugins/migration/changelog/update-sync-add-feature-flag-use-rest-api-for-sending
@@ -0,0 +1,5 @@
+Significance: patch
+Type: changed
+Comment: Updated composer.lock.
+
+
diff --git a/projects/plugins/protect/changelog/update-sync-add-feature-flag-use-rest-api-for-sending b/projects/plugins/protect/changelog/update-sync-add-feature-flag-use-rest-api-for-sending
@@ -0,0 +1,5 @@
+Significance: patch
+Type: changed
+Comment: Updated composer.lock.
+
+
diff --git a/projects/plugins/search/changelog/update-sync-add-feature-flag-use-rest-api-for-sending b/projects/plugins/search/changelog/update-sync-add-feature-flag-use-rest-api-for-sending
@@ -0,0 +1,5 @@
+Significance: patch
+Type: changed
+Comment: Updated composer.lock.
+
+
diff --git a/projects/plugins/social/changelog/update-sync-add-feature-flag-use-rest-api-for-sending b/projects/plugins/social/changelog/update-sync-add-feature-flag-use-rest-api-for-sending
@@ -0,0 +1,5 @@
+Significance: patch
+Type: changed
+Comment: Updated composer.lock.
+
+
diff --git a/...ts/plugins/starter-plugin/changelog/update-sync-add-feature-flag-use-rest-api-for-sending b/...ts/plugins/starter-plugin/changelog/update-sync-add-feature-flag-use-rest-api-for-sending
@@ -0,0 +1,5 @@
+Significance: patch
+Type: changed
+Comment: Updated composer.lock.
+
+
diff --git a/projects/plugins/videopress/changelog/update-sync-add-feature-flag-use-rest-api-for-sending b/projects/plugins/videopress/changelog/update-sync-add-feature-flag-use-rest-api-for-sending
@@ -0,0 +1,5 @@
+Significance: patch
+Type: changed
+Comment: Updated composer.lock.
+
+