s4:libcli/smb2: remove unused 'primary' argument of smb2_session_init()

This also gets rid of a talloc_reference() usage. Signed-off-by: Stefan Metzmacher <[email protected]> Reviewed-by: Volker Lendecke <[email protected]>
httpstorm · Jul 24, 2014 · 78e46d7 · 78e46d7
1 parent cd95937
commit 78e46d7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/source4/libcli/smb2/connect.c b/source4/libcli/smb2/connect.c
@@ -172,7 +172,7 @@ static void smb2_connect_negprot_done(struct tevent_req *subreq)
 	/* This is a hack... */
 	smb2cli_conn_set_max_credits(transport->conn, 30);
 
-	state->session = smb2_session_init(transport, state->gensec_settings, state, true);
+	state->session = smb2_session_init(transport, state->gensec_settings, state);
 	if (tevent_req_nomem(state->session, req)) {
 		return;
 	}

diff --git a/source4/libcli/smb2/session.c b/source4/libcli/smb2/session.c
@@ -36,7 +36,7 @@
  */
 struct smb2_session *smb2_session_init(struct smb2_transport *transport,
 				       struct gensec_settings *settings,
-				       TALLOC_CTX *parent_ctx, bool primary)
+				       TALLOC_CTX *parent_ctx)
 {
 	struct smb2_session *session;
 	NTSTATUS status;
@@ -45,11 +45,7 @@ struct smb2_session *smb2_session_init(struct smb2_transport *transport,
 	if (!session) {
 		return NULL;
 	}
-	if (primary) {
-		session->transport = talloc_steal(session, transport);
-	} else {
-		session->transport = talloc_reference(session, transport);
-	}
+	session->transport = talloc_steal(session, transport);
 
 	session->smbXcli = smbXcli_session_create(session, transport->conn);
 	if (session->smbXcli == NULL) {

diff --git a/source4/torture/smb2/util.c b/source4/torture/smb2/util.c
@@ -323,7 +323,7 @@ bool torture_smb2_session_setup(struct torture_context *tctx,
 
 	session = smb2_session_init(transport,
 				    lpcfg_gensec_settings(tctx, tctx->lp_ctx),
-				    mem_ctx, true);
+				    mem_ctx);
 
 	if (session == NULL) {
 		return false;