Merge pull request socketio#980 from doozr/jsonp-error-crash

Always set the HTTP response in case an error should be returned to the client
huangciyin · Aug 6, 2012 · 46227e7 · 46227e7
2 parents 48ad0d3 + d723d36
commit 46227e7
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/transports/http.js b/lib/transports/http.js
@@ -42,6 +42,10 @@ HTTPTransport.prototype.__proto__ = Transport.prototype;
  */
 
 HTTPTransport.prototype.handleRequest = function (req) {
+
+  // Always set the response in case an error is returned to the client
+  this.response = req.res;
+
   if (req.method == 'POST') {
     var buffer = ''
       , res = req.res
@@ -77,8 +81,6 @@ HTTPTransport.prototype.handleRequest = function (req) {
       headers['Access-Control-Allow-Credentials'] = 'true';
     }
   } else {
-    this.response = req.res;
-
     Transport.prototype.handleRequest.call(this, req);
   }
 };