-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed iOS build breaking #24
base: master
Are you sure you want to change the base?
Conversation
CGRectMake in line 14 is not a proper return type. It is a function. hence it is removed and the menu containing the list of applications to open the file with is created manually in line 37.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I think this should be added too, otherwise the compiling fails... |
In our builds it's compiling without any problems, which makes sense because of the plus it should already use the latest version of react-native for compilation. |
I actually think that 0.20.+ means you get only 0.20 pathes (eg. 0.20.1). You dont get 0.47 which is the version where createJSModules was removed... Weird that it compiles in your env :-/ |
Please merge this. Same issue with react-native "^0.55.4" |
Updated
FileOpenerPackage.java
to no longer override the deprecatedcreateJSModules
method, fixed broken React imports inRNFileOpener.h
and fixedCGRectMake
return type.