Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed iOS build breaking #24

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

nielsdB97
Copy link

@nielsdB97 nielsdB97 commented Oct 24, 2017

Updated FileOpenerPackage.java to no longer override the deprecated createJSModules method, fixed broken React imports in RNFileOpener.h and fixed CGRectMake return type.

Alberto-BaseNet and others added 3 commits September 15, 2017 10:24
CGRectMake in line 14 is not a proper return type. It is a function. hence it is removed and the menu containing the list of applications to open the file with is created manually in line 37.
Copy link

@abdurrahmanekr abdurrahmanekr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wolfy2k
Copy link

wolfy2k commented Nov 23, 2017

I think this should be added too, otherwise the compiling fails...

dossiersolutions@3eb8f9a

@nielsdB97
Copy link
Author

nielsdB97 commented Nov 28, 2017

In our builds it's compiling without any problems, which makes sense because of the plus it should already use the latest version of react-native for compilation.

@wolfy2k
Copy link

wolfy2k commented Nov 28, 2017

I actually think that 0.20.+ means you get only 0.20 pathes (eg. 0.20.1). You dont get 0.47 which is the version where createJSModules was removed... Weird that it compiles in your env :-/

@gaboelnuevo
Copy link

Please merge this. Same issue with react-native "^0.55.4"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants