Skip to content

Commit

Permalink
INSTALL, CodingStyle: Recognize that Clang is an acceptable compiler.
Browse files Browse the repository at this point in the history
Clang has nice static analysis and works well as an Open vSwitch compiler,
so mention it more explicitly.

Signed-off-by: Ben Pfaff <[email protected]>
Acked-by: Ethan Jackson <[email protected]>
  • Loading branch information
blp committed Aug 1, 2013
1 parent 4468099 commit 8a6de51
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 11 deletions.
9 changes: 5 additions & 4 deletions CodingStyle
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,8 @@ older compilers:

As a matter of style, avoid // comments.

Avoid using GCC extensions unless you also add a fallback for
non-GCC compilers. You can, however, use GCC extensions and C99
features in code that compiles only on GNU/Linux (such as
lib/netdev-linux.c), because GCC is the system compiler there.
Avoid using GCC or Clang extensions unless you also add a fallback
for other compilers. You can, however, use C99 features or GCC
extensions also supported by Clang in code that compiles only on
GNU/Linux (such as lib/netdev-linux.c), because GCC is the system
compiler there.
14 changes: 7 additions & 7 deletions INSTALL
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,13 @@ you will need the following software:

- GNU make.

- The GNU C compiler. We generally test with version 4.1, 4.2, or
4.3.
- A C compiler, such as:

* GCC 4.x.

* Clang. Clang 3.4 and later provide useful static semantic
analysis and thread-safety checks. For Ubuntu, there are
nightly built packages available on clang's website.

- libssl, from OpenSSL, is optional but recommended if you plan to
connect the Open vSwitch to an OpenFlow controller. libssl is
Expand All @@ -28,11 +33,6 @@ you will need the following software:
libssl is installed, then Open vSwitch will automatically build
with support for it.

- clang, from LLVM, is optional. It provides useful static semantic
analyzer and thread-safety check. clang version must be 3.4 or
later. For Ubuntu, there are nightly built packages available on
clang's website.

To compile the kernel module on Linux, you must also install the
following. If you cannot build or install the kernel module, you may
use the userspace-only implementation, at a cost in performance. The
Expand Down

0 comments on commit 8a6de51

Please sign in to comment.