Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] translation initiation #282

Merged
merged 10 commits into from
Feb 19, 2025
Merged

Conversation

lbourdois
Copy link
Contributor

Bonjour ! 👋

In this PR you'll find the translation of two notebooks I needed for a project.
Hopefully, this will stimulate the translations for the others.

In addition to the two notebooks, there's a translation of the TOC file, the index.md and an addition of the fr tag for the site documentation files.

Since these are @aymeric-roucher's notebooks and he speaks French, I figure he's probably the most qualified person to review this PR 🧐

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@aymeric-roucher
Copy link
Collaborator

aymeric-roucher commented Feb 12, 2025

@lbourdois this translation is a great idea!
Overall it seems good to me. Maybe some translations could be more idiomatic: in LLM judge notebook, 👩‍🏫 Fournir une échelle indicative à des fins d'orientation. sounds strange, it could be 👩‍🏫 Fournir une échelle indicative pour guider le juge dans ses notations.

One thing to definitely change IMO : "LLM juge" should be "LLM-judge" or "LLM-as-a-judge". Translating everything in French word by word is often more awkward than just keeping the English.

@lbourdois
Copy link
Contributor Author

lbourdois commented Feb 13, 2025

Regarding the translation of “LLM-as-a-judge”, I suggest to use the term in English the first time it appears in the notebook, then simply use the word “juge” (as you do in "Fournir une échelle indicative pour guider le juge dans ses notations.").
I think it seems obvious that when we talk about a judge in this notebook, we're talking about a model, and that having to specify “LLM-as-a-judge” here is akin to a pleonasm complexing the sentences unnecessarily (that's why I decided to use "LLM juge" because putting "LLM comme juge" or "LLM en tant que juge" was too long).

If this approach suits you, I'll do another pass on the LLM judge notebook to proceed as follows in addition to make sentences as explicit as possible.

@aymeric-roucher
Copy link
Collaborator

@lbourdois good idea, this seems fine to me!

@lbourdois
Copy link
Contributor Author

@aymeric-roucher
I modified the llm_judge notebook, put all the files in an “fr” folder and synchronized with the latest version of the repo.
So I think we must be quite good.
Let me know if there's anything still wrong.

@aymeric-roucher
Copy link
Collaborator

2 small changes then lgtm!

@lbourdois
Copy link
Contributor Author

I've corrected it to take into account your comments!

Copy link
Collaborator

@aymeric-roucher aymeric-roucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci beaucoup @lbourdois ! 🤗

@aymeric-roucher aymeric-roucher merged commit 391873a into huggingface:main Feb 19, 2025
@lbourdois
Copy link
Contributor Author

@aymeric-roucher

I forgot to translate the “LLM recipe” and didn't thought to propagate the “LLM judge” correction in the ToC 🙃
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants