Skip to content

Add qodana CI checks #1

Add qodana CI checks

Add qodana CI checks #1

Triggered via pull request September 14, 2024 06:31
Status Success
Total duration 14m 16s
Artifacts

qodana_code_quality.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

822 warnings and 178 notices
C-style array declaration: common/src/main/java/com/jeesite/common/text/PinyinUtils.java#L146
Local variable `c` has C-style array type declaration
C-style array declaration: common/src/main/java/com/jeesite/common/utils/IdcardUtils.java#L33
Field `power` has C-style array type declaration
C-style array declaration: common/src/main/java/com/jeesite/common/utils/IdcardUtils.java#L37
Field `verifyCode` has C-style array type declaration
Condition is covered by further condition: common/src/main/java/com/jeesite/common/utils/excel/ExcelImport.java#L537
Condition 'val != null' covered by subsequent condition 'val instanceof String'
Condition is covered by further condition: common/src/main/java/com/jeesite/common/codec/DesUtils.java#L93
Condition '!"".equals(...)' covered by subsequent condition '!"".equals(...)'
Condition is covered by further condition: modules/core/src/main/java/com/jeesite/modules/sys/web/OnlineController.java#L158
Condition 'pc != null' covered by subsequent condition 'pc instanceof PrincipalCollection'
Constant values: common/src/main/java/com/jeesite/common/utils/IdcardUtils.java#L624
Condition `iYear < year` is always `true` when reached
Constant values: common/src/main/java/com/jeesite/common/io/FileUtils.java#L909
Condition `file != null` is always `true`
Constant values: modules/core/src/main/java/com/jeesite/modules/sys/interceptor/LogInterceptor.java#L61
Condition `startTimeThreadLocal != null` is always `true`
Constant values: common/src/main/java/com/jeesite/common/utils/word/BookMark.java#L512
Condition `builder == null` is always `false`
Constant values: common/src/main/java/com/jeesite/common/reflect/ClassUtils.java#L298
Condition `vfs == null` is always `false`
Constant values: common/src/main/java/com/jeesite/common/codec/DesUtils.java#L93
Condition `!"".equals(firstKey)` is always `true`
Constant values: common/src/main/java/com/jeesite/common/reflect/ReflectUtils.java#L161
Condition `obj != null` is always `true`
Constant values: modules/core/src/main/java/com/jeesite/modules/sys/web/AccountController.java#L240
Condition `"email".equals(validType)` is always `true`
Constant values: common/src/main/java/com/jeesite/common/io/FileUtils.java#L870
Condition `file != null` is always `true`
Constant values: common/src/main/java/com/jeesite/common/utils/IdcardUtils.java#L150
Condition `cArr != null` is always `true`
Constant values: common/src/main/java/com/jeesite/common/reflect/ReflectUtils.java#L433
Condition `clazz != null` is always `true`
Constant values: modules/cms/src/main/java/com/jeesite/modules/cms/service/ArticleService.java#L121
Condition `updateExpiredWeightDate != null` is always `true` when reached
Constant values: modules/core/src/main/java/com/jeesite/modules/sys/web/AccountController.java#L461
Condition `"mobile".equals(validType)` is always `true`
Constant values: common/src/main/java/com/jeesite/common/reflect/ClassUtils.java#L308
Condition `"Using VFS adapter " + vfs == null` is always `false`
Constant values: common/src/main/java/com/jeesite/common/utils/IdcardUtils.java#L203
Condition `cArr != null` is always `true`
Constant values: modules/core/src/main/java/com/jeesite/common/ueditor/upload/BinaryUploader.java#L75
Condition `storageState != null` is always `true`
Constant values: common/src/main/java/com/jeesite/common/codec/DesUtils.java#L357
Result of `(k / pow) % 2` is always '0'
Constant values: common/src/main/java/com/jeesite/common/collect/ListUtils.java#L442
Condition `ss != null` is always `true`
Nullability and data flow problems: common/src/main/java/com/jeesite/common/io/FileUtils.java#L569
Dereference of `files` may produce `NullPointerException`
Nullability and data flow problems: common/src/main/java/com/jeesite/common/io/FileUtils.java#L203
Dereference of `files` may produce `NullPointerException`
Nullability and data flow problems: modules/core/src/main/java/com/jeesite/common/ueditor/ActionEnter.java#L94
Method invocation `toJSONString` may produce `NullPointerException`
Nullability and data flow problems: common/src/main/java/com/jeesite/common/web/http/ServletUtils.java#L313
Method invocation `getRequestURI` may produce `NullPointerException`
Nullability and data flow problems: common/src/main/java/com/jeesite/common/utils/IdcardUtils.java#L470
Method invocation `substring` may produce `NullPointerException`
Nullability and data flow problems: common/src/main/java/com/jeesite/common/reflect/ClassUtils.java#L210
Method invocation `list` may produce `NullPointerException`
Nullability and data flow problems: common/src/main/java/com/jeesite/common/io/FileUtils.java#L312
Dereference of `files` may produce `NullPointerException`
Nullability and data flow problems: common/src/main/java/com/jeesite/common/network/IpUtils.java#L67
Array access `addr[0]` may produce `NullPointerException`
Nullability and data flow problems: modules/core/src/main/java/com/jeesite/modules/sys/utils/EmpUtils.java#L214
Method invocation `getOfficeType` may produce `NullPointerException`
Nullability and data flow problems: common/src/main/java/com/jeesite/common/utils/IdcardUtils.java#L508
Method invocation `substring` may produce `NullPointerException`
Nullability and data flow problems: modules/core/src/main/java/com/jeesite/modules/sys/utils/EmpUtils.java#L256
Method invocation `getOfficeType` may produce `NullPointerException`
Nullability and data flow problems: common/src/main/java/com/jeesite/common/utils/IdcardUtils.java#L557
Method invocation `substring` may produce `NullPointerException`
Nullability and data flow problems: common/src/main/java/com/jeesite/common/utils/IdcardUtils.java#L525
Method invocation `substring` may produce `NullPointerException`
Nullability and data flow problems: modules/core/src/main/java/com/jeesite/modules/sys/web/ConfigController.java#L112
Method invocation `getConfigName` may produce `NullPointerException`
Nullability and data flow problems: common/src/main/java/com/jeesite/common/utils/IdcardUtils.java#L491
Method invocation `substring` may produce `NullPointerException`
Nullability and data flow problems: common/src/main/java/com/jeesite/common/utils/IdcardUtils.java#L542
Method invocation `substring` may produce `NullPointerException`
Nullability and data flow problems: common/src/main/java/com/jeesite/common/network/IpUtils.java#L31
Array access `StringUtils.splitComma(ip)[0]` may produce `NullPointerException`
Nullability and data flow problems: common/src/main/java/com/jeesite/common/io/PropertiesUtils.java#L130
Method invocation `entrySet` may produce `NullPointerException`
Duplicate condition: common/src/main/java/com/jeesite/common/codec/DesUtils.java#L93
Duplicate condition `"".equals(firstKey)`
Duplicate condition: common/src/main/java/com/jeesite/common/codec/DesUtils.java#L93
Duplicate condition `"".equals(firstKey)`
Duplicate throws: modules/core/src/main/java/com/jeesite/common/ueditor/ConfigManager.java#L31
There is a more general exception, 'java.io.IOException', in the throws list already.
Duplicate throws: common/src/main/java/com/jeesite/common/utils/excel/ExcelExport.java#L622
There is a more general exception, 'java.io.IOException', in the throws list already.
Field may be 'final': common/src/main/java/com/jeesite/common/lang/ObjectUtils.java#L247
Field `fstConfiguration` may be 'final'
Infinite loop statement: common/src/main/java/com/jeesite/common/reflect/ClassUtils.java#L596
`for` statement cannot complete without throwing an exception
Integer division in floating-point context: common/src/main/java/com/jeesite/common/lang/DateUtils.java#L194
`(afterTime - beforeTime) / (1000 * 60 * 60 * 24)`: integer division in floating-point context
Javadoc declaration problems: common/src/main/java/com/jeesite/common/utils/word/BookMark.java#L75
`@param ctBookmark` tag description is missing
Javadoc declaration problems: common/src/main/java/com/jeesite/common/io/ResourceUtils.java#L80
`@param locationPattern` tag description is missing
Javadoc declaration problems: common/src/main/java/com/jeesite/common/io/IOUtils.java#L23
`@param filePath` tag description is missing
Javadoc declaration problems: common/src/main/java/com/jeesite/common/io/IOUtils.java#L55
`@param file` tag description is missing
Javadoc declaration problems: common/src/main/java/com/jeesite/common/network/IpUtils.java#L13
`@param request` tag description is missing
Javadoc declaration problems: common/src/main/java/com/jeesite/common/io/ResourceUtils.java#L67
`@param location` tag description is missing
Javadoc declaration problems: common/src/main/java/com/jeesite/common/media/VideoUtils.java#L163
`@param inputFile` tag description is missing
Javadoc declaration problems: common/src/main/java/com/jeesite/common/lang/ObjectUtils.java#L131
`@param ignoreProperties` tag description is missing
Javadoc declaration problems: common/src/main/java/com/jeesite/common/io/PropertiesUtils.java#L318
`@param environment` tag description is missing
Javadoc declaration problems: common/src/main/java/com/jeesite/common/web/http/ServletUtils.java#L110
Exception is not declared to be thrown by method isStaticFile
Javadoc declaration problems: common/src/main/java/com/jeesite/common/image/ZxingUtils.java#L76
`@param contents` tag description is missing
Javadoc declaration problems: common/src/main/java/com/jeesite/common/io/IOUtils.java#L72
`@param filePath` tag description is missing
Javadoc declaration problems: common/src/main/java/com/jeesite/common/media/VideoUtils.java#L149
`@param inputFile` tag description is missing
Javadoc declaration problems: common/src/main/java/com/jeesite/common/io/IOUtils.java#L39
`@param file` tag description is missing
Javadoc declaration problems: common/src/main/java/com/jeesite/common/io/ResourceUtils.java#L56
`@param location` tag description is missing
Javadoc declaration problems: common/src/main/java/com/jeesite/common/utils/word/BookMark.java#L62
`@param ctBookmark` tag description is missing
Javadoc declaration problems: common/src/main/java/com/jeesite/common/io/FileUtils.java#L845
`@param imageBase64` tag description is missing
Javadoc declaration problems: common/src/main/java/com/jeesite/common/image/ZxingUtils.java#L29
`@param contents` tag description is missing
qodana
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Constant values: common/src/main/java/com/jeesite/common/io/FileUtils.java#L473
Value `srcDirName` is always 'null'
Multiple occurrences of the same expression: common/src/main/java/com/jeesite/common/utils/IdcardUtils.java#L353
Multiple occurrences of `card.substring(0, 1).toUpperCase() .toCharArray()[0]`
Multiple occurrences of the same expression: common/src/main/java/com/jeesite/common/utils/IdcardUtils.java#L346
Multiple occurrences of `Integer.valueOf(card.substring(0, 1).toUpperCase() .toCharArray()[0])`
Multiple occurrences of the same expression: common/src/main/java/com/jeesite/common/codec/DesUtils.java#L108
Multiple occurrences of `firstKey != null && !"".equals(firstKey) && secondKey != null && !"".equals(secondKey)`
Multiple occurrences of the same expression: common/src/main/java/com/jeesite/common/codec/DesUtils.java#L184
Multiple occurrences of `firstKey != null && !"".equals(firstKey) && secondKey != null && !"".equals(secondKey) && thirdKey !...`
Multiple occurrences of the same expression: common/src/main/java/com/jeesite/common/codec/DesUtils.java#L140
Multiple occurrences of `firstKey != null && !"".equals(firstKey) && secondKey != null && !"".equals(secondKey) && thirdKey !...`
Multiple occurrences of the same expression: common/src/main/java/com/jeesite/common/utils/IdcardUtils.java#L346
Multiple occurrences of `card.substring(0, 1).toUpperCase() .toCharArray()`
Multiple occurrences of the same expression: common/src/main/java/com/jeesite/common/utils/IdcardUtils.java#L346
Multiple occurrences of `card.substring(0, 1).toUpperCase() .toCharArray()[0]`
Multiple occurrences of the same expression: common/src/main/java/com/jeesite/common/codec/DesUtils.java#L199
Multiple occurrences of `firstKey != null && !"".equals(firstKey) && secondKey != null && !"".equals(secondKey)`
Multiple occurrences of the same expression: common/src/main/java/com/jeesite/common/utils/IdcardUtils.java#L353
Multiple occurrences of `Integer.valueOf(card.substring(0, 1).toUpperCase() .toCharArray()[0]) - 55`
Multiple occurrences of the same expression: common/src/main/java/com/jeesite/common/codec/DesUtils.java#L155
Multiple occurrences of `firstKey != null && !"".equals(firstKey) && secondKey != null && !"".equals(secondKey)`
Multiple occurrences of the same expression: common/src/main/java/com/jeesite/common/utils/IdcardUtils.java#L353
Multiple occurrences of `Integer.valueOf(card.substring(0, 1).toUpperCase() .toCharArray()[0])`
Multiple occurrences of the same expression: common/src/main/java/com/jeesite/common/utils/IdcardUtils.java#L353
Multiple occurrences of `card.substring(0, 1).toUpperCase() .toCharArray()`
Multiple occurrences of the same expression: common/src/main/java/com/jeesite/common/text/DiffMatchPatch.java#L1638
Multiple occurrences of `((rd[j + 1] << 1) | 1) & charMatch`
Multiple occurrences of the same expression: common/src/main/java/com/jeesite/common/utils/IdcardUtils.java#L346
Multiple occurrences of `Integer.valueOf(card.substring(0, 1).toUpperCase() .toCharArray()[0]) - 55`
Multiple occurrences of the same expression: common/src/main/java/com/jeesite/common/text/DiffMatchPatch.java#L1641
Multiple occurrences of `((rd[j + 1] << 1) | 1) & charMatch`
Method can be extracted: common/src/main/java/com/jeesite/common/text/DiffMatchPatch.java#L1722
It's possible to extract method returning 'padding' from a long surrounding method
Method can be extracted: modules/core/src/main/java/com/jeesite/common/ueditor/upload/BinaryUploader.java#L95
It's possible to extract method returning 'thread' from a long surrounding method
Method can be extracted: modules/core/src/main/java/com/jeesite/modules/sys/web/LoginController.java#L298
It's possible to extract method returning 'userType' from a long surrounding method
Method can be extracted: common/src/main/java/com/jeesite/common/lang/StringUtils.java#L233
It's possible to extract method returning 'endHTML' from a long surrounding method