GEODE-8264: add serialization tests for RedisData classes (apache#5260)

* added unit tests for RedishHash, RedisSet, and RedisString.
Currently the tests cover serialization, delta, and equals.

geode-redis/src/test/java/org/apache/geode/redis/internal/data/RedisHashTest.java

@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
+ * agreements. See the NOTICE file distributed with this work for additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ *
+ */
+
+package org.apache.geode.redis.internal.data;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.mockito.Mockito.mock;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Collections;
+
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+import org.apache.geode.DataSerializer;
+import org.apache.geode.cache.Region;
+import org.apache.geode.internal.HeapDataOutputStream;
+import org.apache.geode.internal.InternalDataSerializer;
+import org.apache.geode.internal.serialization.ByteArrayDataInput;
+import org.apache.geode.internal.serialization.DataSerializableFixedID;
+import org.apache.geode.redis.internal.netty.Coder;
+
+public class RedisHashTest {
+
+  @BeforeClass
+  public static void beforeClass() {
+    InternalDataSerializer
+        .getDSFIDSerializer()
+        .registerDSFID(DataSerializableFixedID.REDIS_BYTE_ARRAY_WRAPPER, ByteArrayWrapper.class);
+  }
+
+  @Test
+  public void confirmSerializationIsStable() throws IOException, ClassNotFoundException {
+    RedisHash o1 = createRedisHash("k1", "v1", "k2", "v2");
+    o1.setExpirationTimestampNoDelta(1000);
+    HeapDataOutputStream out = new HeapDataOutputStream(100);
+    DataSerializer.writeObject(o1, out);
+    ByteArrayDataInput in = new ByteArrayDataInput(out.toByteArray());
+    RedisHash o2 = DataSerializer.readObject(in);
+    assertThat(o2).isEqualTo(o1);
+  }
+
+  private RedisHash createRedisHash(String k1, String v1, String k2, String v2) {
+    ArrayList<ByteArrayWrapper> elements = new ArrayList<>();
+    elements.add(createByteArrayWrapper(k1));
+    elements.add(createByteArrayWrapper(v1));
+    elements.add(createByteArrayWrapper(k2));
+    elements.add(createByteArrayWrapper(v2));
+    return new RedisHash(elements);
+  }
+
+  private ByteArrayWrapper createByteArrayWrapper(String str) {
+    return new ByteArrayWrapper(Coder.stringToBytes(str));
+  }
+
+  @Test
+  public void equals_returnsFalse_givenDifferentExpirationTimes() {
+    RedisHash o1 = createRedisHash("k1", "v1", "k2", "v2");
+    o1.setExpirationTimestampNoDelta(1000);
+    RedisHash o2 = createRedisHash("k1", "v1", "k2", "v2");
+    o2.setExpirationTimestampNoDelta(999);
+    assertThat(o1).isNotEqualTo(o2);
+  }
+
+  @Test
+  public void equals_returnsFalse_givenDifferentValueBytes() {
+    RedisHash o1 = createRedisHash("k1", "v1", "k2", "v2");
+    o1.setExpirationTimestampNoDelta(1000);
+    RedisHash o2 = createRedisHash("k1", "v1", "k2", "v3");
+    o2.setExpirationTimestampNoDelta(1000);
+    assertThat(o1).isNotEqualTo(o2);
+  }
+
+  @Test
+  public void equals_returnsTrue_givenEqualValueBytesAndExpiration() {
+    RedisHash o1 = createRedisHash("k1", "v1", "k2", "v2");
+    o1.setExpirationTimestampNoDelta(1000);
+    RedisHash o2 = createRedisHash("k1", "v1", "k2", "v2");
+    o2.setExpirationTimestampNoDelta(1000);
+    assertThat(o1).isEqualTo(o2);
+  }
+
+  @Test
+  public void equals_returnsTrue_givenDifferentEmptyHashes() {
+    RedisHash o1 = new RedisHash(Collections.emptyList());
+    RedisHash o2 = RedisHash.EMPTY;
+    assertThat(o1).isEqualTo(o2);
+    assertThat(o2).isEqualTo(o1);
+  }
+
+  @SuppressWarnings("unchecked")
+  @Test
+  public void hset_stores_delta_that_is_stable() throws IOException {
+    Region<ByteArrayWrapper, RedisData> region = Mockito.mock(Region.class);
+    RedisHash o1 = createRedisHash("k1", "v1", "k2", "v2");
+    ByteArrayWrapper k3 = createByteArrayWrapper("k3");
+    ByteArrayWrapper v3 = createByteArrayWrapper("v3");
+    ArrayList<ByteArrayWrapper> adds = new ArrayList<>();
+    adds.add(k3);
+    adds.add(v3);
+    o1.hset(region, null, adds, false);
+    assertThat(o1.hasDelta()).isTrue();
+    HeapDataOutputStream out = new HeapDataOutputStream(100);
+    o1.toDelta(out);
+    assertThat(o1.hasDelta()).isFalse();
+    ByteArrayDataInput in = new ByteArrayDataInput(out.toByteArray());
+    RedisHash o2 = createRedisHash("k1", "v1", "k2", "v2");
+    assertThat(o2).isNotEqualTo(o1);
+    o2.fromDelta(in);
+    assertThat(o2).isEqualTo(o1);
+  }
+
+  @SuppressWarnings("unchecked")
+  @Test
+  public void hdel_stores_delta_that_is_stable() throws IOException {
+    Region<ByteArrayWrapper, RedisData> region = mock(Region.class);
+    RedisHash o1 = createRedisHash("k1", "v1", "k2", "v2");
+    ByteArrayWrapper k1 = createByteArrayWrapper("k1");
+    ArrayList<ByteArrayWrapper> removes = new ArrayList<>();
+    removes.add(k1);
+    o1.hdel(region, null, removes);
+    assertThat(o1.hasDelta()).isTrue();
+    HeapDataOutputStream out = new HeapDataOutputStream(100);
+    o1.toDelta(out);
+    assertThat(o1.hasDelta()).isFalse();
+    ByteArrayDataInput in = new ByteArrayDataInput(out.toByteArray());
+    RedisHash o2 = createRedisHash("k1", "v1", "k2", "v2");
+    assertThat(o2).isNotEqualTo(o1);
+    o2.fromDelta(in);
+    assertThat(o2).isEqualTo(o1);
+  }
+
+  @SuppressWarnings("unchecked")
+  @Test
+  public void setExpirationTimestamp_stores_delta_that_is_stable() throws IOException {
+    Region<ByteArrayWrapper, RedisData> region = mock(Region.class);
+    RedisHash o1 = createRedisHash("k1", "v1", "k2", "v2");
+    o1.setExpirationTimestamp(region, null, 999);
+    assertThat(o1.hasDelta()).isTrue();
+    HeapDataOutputStream out = new HeapDataOutputStream(100);
+    o1.toDelta(out);
+    assertThat(o1.hasDelta()).isFalse();
+    ByteArrayDataInput in = new ByteArrayDataInput(out.toByteArray());
+    RedisHash o2 = createRedisHash("k1", "v1", "k2", "v2");
+    assertThat(o2).isNotEqualTo(o1);
+    o2.fromDelta(in);
+    assertThat(o2).isEqualTo(o1);
+  }
+}

geode-redis/src/test/java/org/apache/geode/redis/internal/data/RedisSetTest.java

@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
+ * agreements. See the NOTICE file distributed with this work for additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ *
+ */
+
+package org.apache.geode.redis.internal.data;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.mockito.Mockito.mock;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+import org.apache.geode.DataSerializer;
+import org.apache.geode.cache.Region;
+import org.apache.geode.internal.HeapDataOutputStream;
+import org.apache.geode.internal.InternalDataSerializer;
+import org.apache.geode.internal.serialization.ByteArrayDataInput;
+import org.apache.geode.internal.serialization.DataSerializableFixedID;
+
+public class RedisSetTest {
+
+  @BeforeClass
+  public static void beforeClass() {
+    InternalDataSerializer
+        .getDSFIDSerializer()
+        .registerDSFID(DataSerializableFixedID.REDIS_BYTE_ARRAY_WRAPPER, ByteArrayWrapper.class);
+  }
+
+  @Test
+  public void confirmSerializationIsStable() throws IOException, ClassNotFoundException {
+    RedisSet o1 = createRedisSet(1, 2);
+    o1.setExpirationTimestampNoDelta(1000);
+    HeapDataOutputStream out = new HeapDataOutputStream(100);
+    DataSerializer.writeObject(o1, out);
+    ByteArrayDataInput in = new ByteArrayDataInput(out.toByteArray());
+    RedisSet o2 = DataSerializer.readObject(in);
+    assertThat(o2).isEqualTo(o1);
+  }
+
+  private RedisSet createRedisSet(int m1, int m2) {
+    return new RedisSet(Arrays.asList(
+        new ByteArrayWrapper(new byte[] {(byte) m1}),
+        new ByteArrayWrapper(new byte[] {(byte) m2})));
+  }
+
+  @Test
+  public void equals_returnsFalse_givenDifferentExpirationTimes() {
+    RedisSet o1 = createRedisSet(1, 2);
+    o1.setExpirationTimestampNoDelta(1000);
+    RedisSet o2 = createRedisSet(1, 2);
+    o2.setExpirationTimestampNoDelta(999);
+    assertThat(o1).isNotEqualTo(o2);
+  }
+
+  @Test
+  public void equals_returnsFalse_givenDifferentValueBytes() {
+    RedisSet o1 = createRedisSet(1, 2);
+    o1.setExpirationTimestampNoDelta(1000);
+    RedisSet o2 = createRedisSet(1, 3);
+    o2.setExpirationTimestampNoDelta(1000);
+    assertThat(o1).isNotEqualTo(o2);
+  }
+
+  @Test
+  public void equals_returnsTrue_givenEqualValueBytesAndExpiration() {
+    RedisSet o1 = createRedisSet(1, 2);
+    o1.setExpirationTimestampNoDelta(1000);
+    RedisSet o2 = createRedisSet(1, 2);
+    o2.setExpirationTimestampNoDelta(1000);
+    assertThat(o1).isEqualTo(o2);
+  }
+
+  @Test
+  public void equals_returnsTrue_givenDifferentEmptySets() {
+    RedisSet o1 = new RedisSet(Collections.emptyList());
+    RedisSet o2 = RedisSet.EMPTY;
+    assertThat(o1).isEqualTo(o2);
+    assertThat(o2).isEqualTo(o1);
+  }
+
+  @SuppressWarnings("unchecked")
+  @Test
+  public void sadd_stores_delta_that_is_stable() throws IOException {
+    Region<ByteArrayWrapper, RedisData> region = mock(Region.class);
+    RedisSet o1 = createRedisSet(1, 2);
+    ByteArrayWrapper member3 = new ByteArrayWrapper(new byte[] {3});
+    ArrayList<ByteArrayWrapper> adds = new ArrayList<>();
+    adds.add(member3);
+    o1.sadd(adds, region, null);
+    assertThat(o1.hasDelta()).isTrue();
+    HeapDataOutputStream out = new HeapDataOutputStream(100);
+    o1.toDelta(out);
+    assertThat(o1.hasDelta()).isFalse();
+    ByteArrayDataInput in = new ByteArrayDataInput(out.toByteArray());
+    RedisSet o2 = createRedisSet(1, 2);
+    assertThat(o2).isNotEqualTo(o1);
+    o2.fromDelta(in);
+    assertThat(o2).isEqualTo(o1);
+  }
+
+  @SuppressWarnings("unchecked")
+  @Test
+  public void srem_stores_delta_that_is_stable() throws IOException {
+    Region<ByteArrayWrapper, RedisData> region = mock(Region.class);
+    RedisSet o1 = createRedisSet(1, 2);
+    ByteArrayWrapper member1 = new ByteArrayWrapper(new byte[] {1});
+    ArrayList<ByteArrayWrapper> removes = new ArrayList<>();
+    removes.add(member1);
+    o1.srem(removes, region, null);
+    assertThat(o1.hasDelta()).isTrue();
+    HeapDataOutputStream out = new HeapDataOutputStream(100);
+    o1.toDelta(out);
+    assertThat(o1.hasDelta()).isFalse();
+    ByteArrayDataInput in = new ByteArrayDataInput(out.toByteArray());
+    RedisSet o2 = createRedisSet(1, 2);
+    assertThat(o2).isNotEqualTo(o1);
+    o2.fromDelta(in);
+    assertThat(o2).isEqualTo(o1);
+  }
+
+  @SuppressWarnings("unchecked")
+  @Test
+  public void setExpirationTimestamp_stores_delta_that_is_stable() throws IOException {
+    Region<ByteArrayWrapper, RedisData> region = mock(Region.class);
+    RedisSet o1 = createRedisSet(1, 2);
+    o1.setExpirationTimestamp(region, null, 999);
+    assertThat(o1.hasDelta()).isTrue();
+    HeapDataOutputStream out = new HeapDataOutputStream(100);
+    o1.toDelta(out);
+    assertThat(o1.hasDelta()).isFalse();
+    ByteArrayDataInput in = new ByteArrayDataInput(out.toByteArray());
+    RedisSet o2 = createRedisSet(1, 2);
+    assertThat(o2).isNotEqualTo(o1);
+    o2.fromDelta(in);
+    assertThat(o2).isEqualTo(o1);
+  }
+}