Skip to content

Commit

Permalink
reiserfs: fix "new_insert_key may be used uninitialized ..."
Browse files Browse the repository at this point in the history
new_insert_key only makes any sense when it's associated with a
new_insert_ptr, which is initialized to NULL and changed to a
buffer_head when we also initialize new_insert_key.  We can key off of
that to avoid the uninitialized warning.

Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Jeff Mahoney <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: Jan Kara <[email protected]>
Cc: Linus Torvalds <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
jeffmahoney authored and torvalds committed Aug 2, 2016
1 parent e63e88b commit 0a11b9a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion fs/reiserfs/ibalance.c
Original file line number Diff line number Diff line change
Expand Up @@ -1153,8 +1153,9 @@ int balance_internal(struct tree_balance *tb,
insert_ptr);
}

memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE);
insert_ptr[0] = new_insert_ptr;
if (new_insert_ptr)
memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE);

return order;
}

0 comments on commit 0a11b9a

Please sign in to comment.