Skip to content

Commit

Permalink
JFS: use list_move instead of list_del/list_add
Browse files Browse the repository at this point in the history
Using list_move() instead of list_del() + list_add().

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <[email protected]>
Signed-off-by: Dave Kleikamp <[email protected]>
  • Loading branch information
Wei Yongjun authored and kleikamp committed Sep 17, 2012
1 parent 16221d9 commit 550d6da
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions fs/jfs/jfs_txnmgr.c
Original file line number Diff line number Diff line change
Expand Up @@ -2977,12 +2977,9 @@ int jfs_sync(void *arg)
* put back on the anon_list.
*/

/* Take off anon_list */
list_del(&jfs_ip->anon_inode_list);

/* Put on anon_list2 */
list_add(&jfs_ip->anon_inode_list,
&TxAnchor.anon_list2);
/* Move from anon_list to anon_list2 */
list_move(&jfs_ip->anon_inode_list,
&TxAnchor.anon_list2);

TXN_UNLOCK();
iput(ip);
Expand Down

0 comments on commit 550d6da

Please sign in to comment.