Skip to content

Commit

Permalink
net: diag: add missing declarations
Browse files Browse the repository at this point in the history
The functions inet_diag_msg_common_fill and inet_diag_msg_attrs_fill
seem to have been missed from the include/linux/inet_diag.h header
file. Add them to fix the following warnings:

net/ipv4/inet_diag.c:69:6: warning: symbol 'inet_diag_msg_common_fill' was not declared. Should it be static?
net/ipv4/inet_diag.c:108:5: warning: symbol 'inet_diag_msg_attrs_fill' was not declared. Should it be static?

Signed-off-by: Ben Dooks <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
bjdooks-ct authored and davem330 committed Jun 11, 2016
1 parent 56fae40 commit c3ec5e5
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 6 additions & 0 deletions include/linux/inet_diag.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,12 @@ struct sock *inet_diag_find_one_icsk(struct net *net,

int inet_diag_bc_sk(const struct nlattr *_bc, struct sock *sk);

void inet_diag_msg_common_fill(struct inet_diag_msg *r, struct sock *sk);

int inet_diag_msg_attrs_fill(struct sock *sk, struct sk_buff *skb,
struct inet_diag_msg *r, int ext,
struct user_namespace *user_ns);

extern int inet_diag_register(const struct inet_diag_handler *handler);
extern void inet_diag_unregister(const struct inet_diag_handler *handler);
#endif /* _INET_DIAG_H_ */
6 changes: 0 additions & 6 deletions net/sctp/sctp_diag.c
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,6 @@
#include <linux/sock_diag.h>
#include <net/sctp/sctp.h>

extern void inet_diag_msg_common_fill(struct inet_diag_msg *r,
struct sock *sk);
extern int inet_diag_msg_attrs_fill(struct sock *sk, struct sk_buff *skb,
struct inet_diag_msg *r, int ext,
struct user_namespace *user_ns);

static void sctp_diag_get_info(struct sock *sk, struct inet_diag_msg *r,
void *info);

Expand Down

0 comments on commit c3ec5e5

Please sign in to comment.