IB/core: Fix oops in ib_cache_gid_set_default_gid

When we fail to find the default gid index, we can't continue processing in this routine or else we will pass a negative index to later routines resulting in invalid memory access attempts and a kernel oops. Fixes: 03db3a2 (IB/core: Add RoCE GID table management) Signed-off-by: Doug Ledford <[email protected]>
huntrar · Apr 23, 2016 · d29c9ab · d29c9ab
1 parent 5f44abd
commit d29c9ab
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/drivers/infiniband/core/cache.c b/drivers/infiniband/core/cache.c
@@ -691,7 +691,8 @@ void ib_cache_gid_set_default_gid(struct ib_device *ib_dev, u8 port,
 			      NULL);
 
 		/* Coudn't find default GID location */
-		WARN_ON(ix < 0);
+		if (WARN_ON(ix < 0))
+			goto release;
 
 		zattr_type.gid_type = gid_type;