Merge pull request mozilla-services#2097 from uberj/bug_1021850

Fail with a useful error message and add unzip to required packages
huoxudong125 · Jun 10, 2014 · fb33ef3 · fb33ef3
2 parents d33d0e6 + c402acf
commit fb33ef3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/puppet/manifests/socorro.pp b/puppet/manifests/socorro.pp
@@ -87,6 +87,7 @@
       'mod_wsgi',
       'memcached',
       'daemonize',
+      'unzip',
     ]:
     ensure => latest
   }

diff --git a/socorro/unittest/cron/jobs/test_symbolsunpack.py b/socorro/unittest/cron/jobs/test_symbolsunpack.py
@@ -147,7 +147,9 @@ def test_symbols_unpack_subdirectories_careful_dir_cleanup(self):
 
         information = self._load_structure()
         assert information['symbols-unpack']
-        assert not information['symbols-unpack']['last_error']
+        assert not information['symbols-unpack']['last_error'], (
+            information['symbols-unpack']['last_error']
+        )
         assert information['symbols-unpack']['last_success']
 
         ok_(os.listdir(self.temp_destination_directory), 'empty')