Skip to content

Commit

Permalink
Don't set ENABLE_WERROR in VMR CI build in mono.proj (dotnet#99604)
Browse files Browse the repository at this point in the history
We can have different machine configuration in the VMR context so we don't want to potentially break the build on warnings there.

Fixes dotnet/source-build#4197 (comment)
  • Loading branch information
akoeplinger authored Mar 13, 2024
1 parent 75a0248 commit 5af0433
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/mono/mono.proj
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
</PropertyGroup>

<!-- CI specific build options -->
<ItemGroup Condition="'$(ContinuousIntegrationBuild)' == 'true' and ('$(TargetsOSX)' == 'true' or '$(TargetsMacCatalyst)' == 'true' or '$(TargetsBrowser)' == 'true' or '$(TargetsWasi)' == 'true' or '$(Targetsillumos)' == 'true')">
<ItemGroup Condition="'$(ContinuousIntegrationBuild)' == 'true' and '$(DotNetBuildOrchestrator)' != 'true' and ('$(TargetsOSX)' == 'true' or '$(TargetsMacCatalyst)' == 'true' or '$(TargetsBrowser)' == 'true' or '$(TargetsWasi)' == 'true' or '$(Targetsillumos)' == 'true')">
<_MonoCMakeArgs Include="-DENABLE_WERROR=1"/>
</ItemGroup>

Expand Down

0 comments on commit 5af0433

Please sign in to comment.