improve DebugTab screen updates a bit

hussainbohra · Jun 15, 2012 · b61f13c · b61f13c
1 parent 0b1fc6e
commit b61f13c
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 10 deletions.
diff --git a/org.erlide.ui/src/org/erlide/ui/launch/DebugTab.java b/org.erlide.ui/src/org/erlide/ui/launch/DebugTab.java
@@ -289,9 +289,9 @@ public static void addModules(final Collection<String> interpret,
                 if (p != null) {
                     final String mName = pm[1];
                     try {
-                        final String s = CommonUtils
-                                .isErlangFileContentFileName(mName) ? mName
-                                : mName + ".erl";
+                        final boolean isErlangFile = CommonUtils
+                                .isErlangFileContentFileName(mName);
+                        final String s = isErlangFile ? mName : mName + ".erl";
                         module = p.getModule(s);
                     } catch (final ErlModelException e) {
                         ErlLogger.warn(e);

diff --git a/org.erlide.ui/src/org/erlide/ui/launch/DebugTreeItem.java b/org.erlide.ui/src/org/erlide/ui/launch/DebugTreeItem.java
@@ -117,18 +117,22 @@ private void updateMenuCategoryCheckedState(
     }
 
     public void setChecked(final CheckboxTreeViewer checkboxTreeViewer,
-            final Collection<IErlModule> list) {
+            final Collection<IErlModule> modules) {
         final Control tree = checkboxTreeViewer.getControl();
         tree.setRedraw(false);
         try {
-            setGrayChecked(checkboxTreeViewer, false, list.contains(item));
-            for (final DebugTreeItem c : children) {
-                c.setChecked(checkboxTreeViewer, list);
-                c.getParent()
-                        .updateMenuCategoryCheckedState(checkboxTreeViewer);
-            }
+            doSetChecked(checkboxTreeViewer, modules);
         } finally {
             tree.setRedraw(true);
         }
     }
+
+    private void doSetChecked(final CheckboxTreeViewer checkboxTreeViewer,
+            final Collection<IErlModule> modules) {
+        setGrayChecked(checkboxTreeViewer, false, modules.contains(item));
+        for (final DebugTreeItem c : children) {
+            c.setChecked(checkboxTreeViewer, modules);
+            c.getParent().updateMenuCategoryCheckedState(checkboxTreeViewer);
+        }
+    }
 }