Skip to content

Commit

Permalink
ofproto: Rename "private.h" to "ofproto->provider.h".
Browse files Browse the repository at this point in the history
To be more consistent with other providers, rename "private.h" to
"ofproto-provider.h".
  • Loading branch information
Justin Pettit committed Jul 1, 2011
1 parent b69fe6b commit 5bee6e2
Show file tree
Hide file tree
Showing 8 changed files with 17 additions and 17 deletions.
6 changes: 3 additions & 3 deletions PORTING
Original file line number Diff line number Diff line change
Expand Up @@ -160,9 +160,9 @@ ofproto Providers

An "ofproto provider" is what ofproto uses to directly monitor and
control an OpenFlow-capable switch. struct ofproto_class, in
ofproto/private.h, defines the interfaces to implement an ofproto
provider for new hardware or software. That structure contains many
function pointers, each of which has a comment that is meant to
ofproto/ofproto-provider.h, defines the interfaces to implement an
ofproto provider for new hardware or software. That structure contains
many function pointers, each of which has a comment that is meant to
describe its behavior in detail. If the requirements are unclear,
please report this as a bug.

Expand Down
4 changes: 2 additions & 2 deletions ofproto/automake.mk
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ ofproto_libofproto_a_SOURCES = \
ofproto/ofproto-dpif.c \
ofproto/ofproto-dpif-sflow.c \
ofproto/ofproto-dpif-sflow.h \
ofproto/ofproto-provider.h \
ofproto/pktbuf.c \
ofproto/pktbuf.h \
ofproto/pinsched.c \
ofproto/pinsched.h \
ofproto/private.h
ofproto/pinsched.h

EXTRA_DIST += ofproto/ofproto-unixctl.man
2 changes: 1 addition & 1 deletion ofproto/connmgr.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@
#include "odp-util.h"
#include "ofp-util.h"
#include "ofpbuf.h"
#include "ofproto-provider.h"
#include "pinsched.h"
#include "poll-loop.h"
#include "pktbuf.h"
#include "private.h"
#include "rconn.h"
#include "shash.h"
#include "timeval.h"
Expand Down
2 changes: 1 addition & 1 deletion ofproto/fail-open.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
#include "ofp-util.h"
#include "ofpbuf.h"
#include "ofproto.h"
#include "ofproto-provider.h"
#include "pktbuf.h"
#include "poll-loop.h"
#include "private.h"
#include "rconn.h"
#include "timeval.h"
#include "vconn.h"
Expand Down
2 changes: 1 addition & 1 deletion ofproto/in-band.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@
#include "odp-util.h"
#include "ofproto.h"
#include "ofpbuf.h"
#include "ofproto-provider.h"
#include "openflow/openflow.h"
#include "packets.h"
#include "poll-loop.h"
#include "private.h"
#include "timeval.h"
#include "vlog.h"

Expand Down
2 changes: 1 addition & 1 deletion ofproto/ofproto-dpif.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

#include <config.h>

#include "ofproto/private.h"
#include "ofproto/ofproto-provider.h"

#include <errno.h>

Expand Down
6 changes: 3 additions & 3 deletions ofproto/private.h → ofproto/ofproto-provider.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
* limitations under the License.
*/

#ifndef OFPROTO_PRIVATE_H
#define OFPROTO_PRIVATE_H 1
#ifndef OFPROTO_OFPROTO_PROVIDER_H
#define OFPROTO_OFPROTO_PROVIDER_H 1

/* Definitions for use within ofproto. */

Expand Down Expand Up @@ -923,4 +923,4 @@ void ofproto_add_flow(struct ofproto *, const struct cls_rule *,
bool ofproto_delete_flow(struct ofproto *, const struct cls_rule *);
void ofproto_flush_flows(struct ofproto *);

#endif /* ofproto/private.h */
#endif /* ofproto/ofproto-provider.h */
10 changes: 5 additions & 5 deletions ofproto/ofproto.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@
#include "ofp-print.h"
#include "ofp-util.h"
#include "ofpbuf.h"
#include "ofproto-provider.h"
#include "openflow/nicira-ext.h"
#include "openflow/openflow.h"
#include "packets.h"
#include "pinsched.h"
#include "pktbuf.h"
#include "poll-loop.h"
#include "private.h"
#include "shash.h"
#include "sset.h"
#include "timeval.h"
Expand Down Expand Up @@ -1369,8 +1369,8 @@ ofproto_rule_destroy__(struct rule *rule)
/* This function allows an ofproto implementation to destroy any rules that
* remain when its ->destruct() function is called. The caller must have
* already uninitialized any derived members of 'rule' (step 5 described in the
* large comment in ofproto/private.h titled "Life Cycle"). This function
* implements steps 6 and 7.
* large comment in ofproto/ofproto-provider.h titled "Life Cycle").
* This function implements steps 6 and 7.
*
* This function should only be called from an ofproto implementation's
* ->destruct() function. It is not suitable elsewhere. */
Expand Down Expand Up @@ -2800,8 +2800,8 @@ ofoperation_destroy(struct ofoperation *op)
* If 'op' is a "delete flow" operation, 'error' must be 0. That is, flow
* deletions are not allowed to fail.
*
* Please see the large comment in ofproto/private.h titled "Asynchronous
* Operation Support" for more information. */
* Please see the large comment in ofproto/ofproto-provider.h titled
* "Asynchronous Operation Support" for more information. */
void
ofoperation_complete(struct ofoperation *op, int error)
{
Expand Down

0 comments on commit 5bee6e2

Please sign in to comment.