Skip to content

Commit

Permalink
apply: get rid of useless x < 0 comparison on a size_t type
Browse files Browse the repository at this point in the history
According to the C standard size_t is always unsigned, therefore the
comparison "n1 < 0 || n2 < 0" when n1 and n2 are size_t will always be
false.

This was raised by clang 2.9 which throws this warning when compiling
apply.c:

    builtin/apply.c:253:9: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
            if (n1 < 0 || n2 < 0)
                ~~ ^ ~
    builtin/apply.c:253:19: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
            if (n1 < 0 || n2 < 0)
                          ~~ ^ ~

This check was originally added in v1.6.5-rc0~53^2 by Giuseppe Bilotta
while adding an option to git-apply to ignore whitespace differences.

Signed-off-by: Ævar Arnfjörð Bjarmason <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
  • Loading branch information
avar authored and gitster committed Nov 6, 2011
1 parent 703f05a commit 473f4c9
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions builtin/apply.c
Original file line number Diff line number Diff line change
Expand Up @@ -250,9 +250,6 @@ static int fuzzy_matchlines(const char *s1, size_t n1,
const char *last2 = s2 + n2 - 1;
int result = 0;

if (n1 < 0 || n2 < 0)
return 0;

/* ignore line endings */
while ((*last1 == '\r') || (*last1 == '\n'))
last1--;
Expand Down

0 comments on commit 473f4c9

Please sign in to comment.