OcFileLib: Provide workaround for buggy drivers

huytbt · Jul 16, 2020 · 592d2ac · 592d2ac
1 parent 7b445b2
commit 592d2ac
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/Library/OcFileLib/GetFileInfo.c b/Library/OcFileLib/GetFileInfo.c
@@ -27,6 +27,7 @@
 #include <Library/UefiBootServicesTableLib.h>
 #include <Library/OcDevicePathLib.h>
 #include <Library/OcFileLib.h>
+#include <Library/OcGuardLib.h>
 
 VOID *
 GetFileInfo (
@@ -52,6 +53,12 @@ GetFileInfo (
                    );
 
   if (Status == EFI_BUFFER_TOO_SMALL && FileInfoSize >= MinFileInfoSize) {
+    //
+    // Some drivers (i.e. built-in 32-bit Apple HFS driver) may possibly omit null terminators from file info data.
+    //
+    if (CompareGuid (InformationType, &gEfiFileInfoGuid) && OcOverflowAddUN (FileInfoSize, sizeof (CHAR16), &FileInfoSize)) {
+      return NULL;
+    }
     FileInfoBuffer = AllocateZeroPool (FileInfoSize);
 
     if (FileInfoBuffer != NULL) {