Merge pull request #64 from hwgilbert16/develop

Hotfix: Fix issue with malformed HTTP responses
hwgilbert16 · Nov 10, 2023 · bf3eef6 · bf3eef6
2 parents 03ef9c0 + f8bd37b
commit bf3eef6
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -21,7 +21,9 @@ WORKDIR /usr/src/app
 
 COPY package*.json .
 
-RUN npm install --production --silent --legacy-peer-deps
+RUN apk add g++ make py3-pip
+RUN npm install --production --silent --unsafe-perm --legacy-peer-deps
+RUN apk del g++ make py3-pip
 
 COPY . .
 

diff --git a/apps/api/src/main.ts b/apps/api/src/main.ts
@@ -70,10 +70,9 @@ async function bootstrap() {
   fs.writeFileSync("./dist/api-spec.json", JSON.stringify(document));
   SwaggerModule.setup("api", app, document);
 
-  const port = process.env.HTTP_PORT || 8080;
   await app.init();
 
-  http.createServer(server).listen(port);
+  http.createServer(server).listen(process.env.HTTP_PORT);
 }
 
 bootstrap();
diff --git a/compose.yml b/compose.yml
@@ -25,11 +25,12 @@ services:
     image: hwgilbert16/scholarsome:latest
     platform: "linux/amd64"
     ports:
-      - "${HTTP_PORT}:8080"
+      - "${HTTP_PORT}:${HTTP_PORT}"
     environment:
       - "NODE_ENV=${NODE_ENV}"
       - "DATABASE_URL=mysql://scholarsome:${DATABASE_PASSWORD}@mariadb:3306/scholarsome"
       - "JWT_SECRET=${JWT_SECRET}"
+      - "HTTP_PORT=${HTTP_PORT}"
       - "STORAGE_TYPE=${STORAGE_TYPE}"
       - "REDIS_HOST=redis"
       - "REDIS_PORT=6379"

diff --git a/package-lock.json b/package-lock.json